From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: discoverability, better defaults and which-key in Emacs Date: Thu, 08 Feb 2024 08:59:58 +0200 Message-ID: <86a5obxwy9.fsf@gnu.org> References: <874jetaxri.fsf@jeremybryant.net> <87le84oqbd.fsf@yahoo.com> <87plxdpsxw.fsf@posteo.net> <87r0hridvr.fsf@posteo.net> <5dd3d04c-c0eb-43fe-b7c2-957f80261ea3@gutov.dev> <87eddqiw84.fsf@posteo.net> <32071337-c91d-46ad-bb9b-10b8d0c83965@gutov.dev> <86h6ikzc38.fsf@gnu.org> <1056a72d-af5c-487e-be33-67522fe47d17@gutov.dev> <87r0hnohgv.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38355"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, justin@burkett.cc, philipk@posteo.net, luangruo@yahoo.com, jb@jeremybryant.net, emacs-devel@gnu.org To: Visuwesh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 08 08:00:56 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rXyP2-0009nR-9e for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Feb 2024 08:00:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXyOD-0001zU-OQ; Thu, 08 Feb 2024 02:00:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXyOB-0001z5-Gj for emacs-devel@gnu.org; Thu, 08 Feb 2024 02:00:03 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXyOA-0008Hw-Li; Thu, 08 Feb 2024 02:00:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=v9lBQdNrfdVShql2CpC6RfFZaxISHna5DQINMFWqco0=; b=eBoB/KaFASGufDKvYMTM cZYkn3ggHE8+Qxp/jRGfbKUxYpg6Znf12oZKoUIK7hJSkqsQwd15MxWoruYjLmJ3Dxq5MTOrT1wKJ FBSqPlDkIBElglmqYSed/CL52Agr1RFXO+YAD5oGSsIpdUVmo+Y0sCgl3VJeLUzuTT6hppm1Sbse1 hgiIOwKcIh3ghGw+hXe2wOTLYztpVMO7lBT3CZ5cuU4pj2xNrcg4TZJ8pwLZOjv2gngBENYhSoDan Pa6qoSUlHur6b4UvS8Plrmi9rptXRryFsds+jH4o7jTHAqdTlBIpj/MTx5hHGA920RFGUKUjm2Mtl hCsxoGNElRMIhg==; In-Reply-To: <87r0hnohgv.fsf@gmail.com> (message from Visuwesh on Thu, 08 Feb 2024 07:16:56 +0530) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316019 Archived-At: > From: Visuwesh > Cc: Eli Zaretskii , justin@burkett.cc, philipk@posteo.net, > luangruo@yahoo.com, jb@jeremybryant.net, emacs-devel@gnu.org > Date: Thu, 08 Feb 2024 07:16:56 +0530 > > [புதன் பிப்ரவரி 07, 2024] Dmitry Gutov wrote: > > > [...] > > diff --git a/src/keyboard.c b/src/keyboard.c > > index 1f7253a7da1..6d3db5ab615 100644 > > --- a/src/keyboard.c > > +++ b/src/keyboard.c > > @@ -589,6 +589,15 @@ echo_dash (void) > > AUTO_STRING (dash, "-"); > > kset_echo_string (current_kboard, > > concat2 (KVAR (current_kboard, echo_string), dash)); > > + > > + if (echo_keystrokes_help) > > + { > > + AUTO_STRING (help, " (\\`C-h' for help)"); > ^^^^^^^ > > Shouldn't this part use the value of help-char instead? (There's also > the complication with help-form.) I'm not sure using help-char here is TRT: that character is only in effect in this situation of it has no binding prefixed by what the user already typed. So the effect of changing help-char could be confusing for newbies, who are the main audience of this feature. But I added F1 to that text, which should help if someone did change help-char. Thanks.