all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dmitry@gutov.dev>,
	Stefan Monnier <monnier@iro.umontreal.ca>
Cc: visuweshm@gmail.com, justin@burkett.cc, philipk@posteo.net,
	luangruo@yahoo.com, jb@jeremybryant.net, emacs-devel@gnu.org
Subject: Re: discoverability, better defaults and which-key in Emacs
Date: Thu, 08 Feb 2024 18:50:25 +0200	[thread overview]
Message-ID: <86il2yx5m6.fsf@gnu.org> (raw)
In-Reply-To: <941e2791-bb35-4de6-b7a7-e3dce4938a1d@gutov.dev> (message from Dmitry Gutov on Thu, 8 Feb 2024 16:43:41 +0200)

> Date: Thu, 8 Feb 2024 16:43:41 +0200
> Cc: visuweshm@gmail.com, justin@burkett.cc, philipk@posteo.net,
>  luangruo@yahoo.com, jb@jeremybryant.net, emacs-devel@gnu.org
> From: Dmitry Gutov <dmitry@gutov.dev>
> 
> >> If we consider the situations where C-h or f1 is rebound, having
> >> misleading text in the message (with bindings that don't work) should
> >> concern us as well. Even if one of the suggestions is likely to work
> >> anyway (while the other doesn't).
> > If you can come up with a code that detects at run time that help-key
> > and/or F1 was rebound to a key that will not invoke
> > describe-prefix-bindings, such a key should indeed better be removed
> > from the message.  But can we reliably do that?  If we cannot, having
> > two keys there instead of one is better.
> 
> I think we should be able to, but since help-key doesn't call any 
> command directly through a map or fallback binding of some sort (instead 
> it's dispatched ad-hoc), the solution I have tried so far (also using 
> substitute-command-keys) did not help.

Maybe Stefan (CC'ed) could have an idea.  In general, since the key
sequence was just echoed, we do know what sequence was typed, and can
test whether adding help-char to it would produce a binding, like what
we do in read_key_sequence where we decide whether to invoke
prefix-help-command.



  parent reply	other threads:[~2024-02-08 16:50 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 23:23 discoverability, better defaults and which-key in Emacs Jeremy Bryant
2024-02-01  2:45 ` Po Lu
2024-02-03 13:40   ` Philip Kaludercic
2024-02-04 22:03     ` Dmitry Gutov
2024-02-05  7:11       ` Philip Kaludercic
2024-02-05 15:38         ` Dmitry Gutov
2024-02-05 18:47           ` Philip Kaludercic
2024-02-05 19:17             ` Dmitry Gutov
2024-02-05 19:33               ` Justin Burkett
2024-02-05 23:05                 ` Dmitry Gutov
2024-02-06  2:49                   ` Justin Burkett
2024-02-06 23:12                     ` Dmitry Gutov
2024-02-07 12:35                       ` Eli Zaretskii
2024-02-07 18:31                         ` Dmitry Gutov
2024-02-07 19:13                           ` Eli Zaretskii
2024-02-07 19:51                             ` Dmitry Gutov
2024-02-08  1:46                           ` Visuwesh
2024-02-08  6:59                             ` Eli Zaretskii
2024-02-08 12:18                               ` Dmitry Gutov
2024-02-08 13:02                                 ` Eli Zaretskii
2024-02-08 13:36                                   ` Dmitry Gutov
2024-02-08 13:52                                     ` Eli Zaretskii
2024-02-08 14:43                                       ` Dmitry Gutov
2024-02-08 16:12                                         ` Dmitry Gutov
2024-02-11  2:17                                           ` Dmitry Gutov
2024-02-11  2:39                                             ` Po Lu
2024-02-11 12:30                                               ` Dmitry Gutov
2024-02-11  6:49                                             ` Eli Zaretskii
2024-02-11 12:26                                               ` Dmitry Gutov
2024-02-11 15:00                                                 ` Eli Zaretskii
2024-02-11 20:36                                                   ` Dmitry Gutov
2024-02-08 16:50                                         ` Eli Zaretskii [this message]
2024-02-08 13:41                                   ` Dmitry Gutov
2024-02-08 13:51                                   ` Rebinding Fn [Re: discoverability, better defaults and which-key in Emacs] Alan Mackenzie
2024-02-08 13:55                                     ` Eli Zaretskii
2024-02-08 14:04                                       ` Alan Mackenzie
2024-02-08 13:25                           ` discoverability, better defaults and which-key in Emacs Po Lu
2024-02-08 13:27                             ` Dmitry Gutov
2024-02-08 13:36                               ` Dmitry Gutov
2024-02-01  7:35 ` Eli Zaretskii
2024-02-01 21:16   ` Jeremy Bryant
2024-02-02  6:43     ` Eli Zaretskii
2024-02-02  7:00       ` Emanuel Berg
2024-02-02  7:43         ` Eli Zaretskii
2024-02-02 15:25           ` [External] : " Drew Adams
2024-02-02 15:53             ` Emanuel Berg
2024-02-02 16:04             ` Emanuel Berg
2024-02-03 11:46             ` Jeremy Bryant
2024-02-03 11:39           ` Jeremy Bryant
2024-02-03 12:12             ` Eli Zaretskii
2024-02-03 14:07               ` Jeremy Bryant
2024-02-03 15:15                 ` Eli Zaretskii
2024-02-04 22:18                   ` Jeremy Bryant
2024-02-05 12:41                     ` Eli Zaretskii
2024-02-03 11:30       ` Jeremy Bryant
2024-02-03 11:36       ` Moving which-key ELPA package into core - " Jeremy Bryant
2024-02-03 16:34         ` Stefan Monnier
2024-02-04 22:12           ` Jeremy Bryant
2024-02-04 23:06             ` Stefan Monnier
2024-02-01 21:17   ` orzodk
2024-02-01 22:24     ` Jeremy Bryant
2024-02-01 23:49       ` orzodk
2024-02-02  6:31     ` Eli Zaretskii
2024-02-02 16:00   ` Howard Melman
2024-02-02 19:24     ` Eli Zaretskii
2024-02-02 19:32       ` tomas
2024-02-02 20:16         ` Howard Melman
2024-02-03  7:25           ` Emanuel Berg
2024-02-03  8:49           ` Eli Zaretskii
2024-02-03 16:58             ` [External] : " Drew Adams
2024-02-04 22:25               ` Jeremy Bryant
2024-02-04 22:55                 ` Emanuel Berg
2024-02-05  3:40                   ` Emanuel Berg
2024-02-04 23:47                 ` Drew Adams
2024-02-05  1:46                   ` Emanuel Berg
2024-02-05  3:52               ` Divya Ranjan
2024-02-05 15:04                 ` Drew Adams
2024-02-04 18:34             ` Howard Melman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86il2yx5m6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dmitry@gutov.dev \
    --cc=emacs-devel@gnu.org \
    --cc=jb@jeremybryant.net \
    --cc=justin@burkett.cc \
    --cc=luangruo@yahoo.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=philipk@posteo.net \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.