all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 69079@debbugs.gnu.org
Subject: bug#69079: [PATCH] Add 'customize-toggle-option' command
Date: Tue, 13 Feb 2024 14:40:49 +0200	[thread overview]
Message-ID: <864jecr0z2.fsf@gnu.org> (raw)
In-Reply-To: <87r0hh1aq9.fsf@posteo.net> (message from Philip Kaludercic on Tue, 13 Feb 2024 00:14:38 +0000)

> From: Philip Kaludercic <philipk@posteo.net>
> Cc: 69079@debbugs.gnu.org
> Date: Tue, 13 Feb 2024 00:14:38 +0000
> 
> >> My assumption was that the command would only be invoked interactivly,
> >> so I can either make that explicit with an `interactive-only' or repeat
> >> the check.  What do you think would be better?
> >
> > I think an explicit test is better, since then we get to display a
> > user-friendly error message, instead of relying on Lisp errors to
> > explain themselves.
> >
> > Btw, are you sure that the users can never succeed in inputting a
> > non-boolean option with the way you prompt them?
> 
> No, that was not ensured, and I think it is better not to.  I have
> adjusted the patch to check and prompt the user if the user option is
> non-boolean, in case they know what they are doing.  WDYT?

LGTM, although I haven't tried to actually use the code.

Thanks.





  reply	other threads:[~2024-02-13 12:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12 17:32 bug#69079: [PATCH] Add 'customize-toggle-option' command Philip Kaludercic
2024-02-12 17:47 ` Eli Zaretskii
2024-02-12 18:41   ` Drew Adams
2024-02-12 18:56   ` Philip Kaludercic
2024-02-12 19:32     ` Eli Zaretskii
2024-02-13  0:14       ` Philip Kaludercic
2024-02-13 12:40         ` Eli Zaretskii [this message]
2024-02-13 12:46           ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-13 20:09             ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=864jecr0z2.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=69079@debbugs.gnu.org \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.