From: Philip Kaludercic <philipk@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 69079@debbugs.gnu.org
Subject: bug#69079: [PATCH] Add 'customize-toggle-option' command
Date: Tue, 13 Feb 2024 00:14:38 +0000 [thread overview]
Message-ID: <87r0hh1aq9.fsf@posteo.net> (raw)
In-Reply-To: <86frxxqxzw.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Feb 2024 21:32:51 +0200")
[-- Attachment #1: Type: text/plain, Size: 1724 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Philip Kaludercic <philipk@posteo.net>
>> Cc: 69079@debbugs.gnu.org
>> Date: Mon, 12 Feb 2024 18:56:39 +0000
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> >> From: Philip Kaludercic <philipk@posteo.net>
>> >> Date: Mon, 12 Feb 2024 17:32:37 +0000
>> >>
>> >> +;;;###autoload
>> >> +(defun customize-toggle-option (opt)
>> >> + "Toggle the value of boolean option OPT for this session."
>> >> + (interactive (let (opts)
>> >> + (mapatoms
>> >> + (lambda (sym)
>> >> + (when (eq (get sym 'custom-type) 'boolean)
>> >> + (push sym opts))))
>> >> + (list (intern (completing-read "Option: " opts)))))
>> >> + (message "%s user options '%s'."
>> >> + (if (funcall (or (get opt 'custom-set) #'set-default)
>> >> + opt (not (funcall (or (get opt 'custom-get)
>> >> + #'symbol-value)
>> >> + opt)))
>> >> + "Enabled" "Disabled")
>> >> + opt))
>> >
>> > Shouldn't this have some validation? what if the argument OPT is
>> > not a
>> > boolean?
>>
>> My assumption was that the command would only be invoked interactivly,
>> so I can either make that explicit with an `interactive-only' or repeat
>> the check. What do you think would be better?
>
> I think an explicit test is better, since then we get to display a
> user-friendly error message, instead of relying on Lisp errors to
> explain themselves.
>
> Btw, are you sure that the users can never succeed in inputting a
> non-boolean option with the way you prompt them?
No, that was not ensured, and I think it is better not to. I have
adjusted the patch to check and prompt the user if the user option is
non-boolean, in case they know what they are doing. WDYT?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-custom-variable-command.patch --]
[-- Type: text/x-patch, Size: 2620 bytes --]
From abb72681c82e30a52bcfa90174e0677757174971 Mon Sep 17 00:00:00 2001
From: Philip Kaludercic <philipk@posteo.net>
Date: Mon, 12 Feb 2024 18:29:50 +0100
Subject: [PATCH] Add 'custom-variable' command.
* lisp/cus-edit.el (customize-toggle-option): Add command.
(toggle-option): Add shorter alias for 'customize-toggle-option'.
* etc/NEWS: Document it.
---
etc/NEWS | 4 ++++
lisp/cus-edit.el | 34 ++++++++++++++++++++++++++++++++++
2 files changed, 38 insertions(+)
diff --git a/etc/NEWS b/etc/NEWS
index afc2c22e68b..6fae64728f2 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1329,6 +1329,10 @@ in Buffer menu mode.
*** New command 'customize-dirlocals'.
This command pops up a buffer to edit the settings in ".dir-locals.el".
+---
+** New command 'customize-toggle-option'.
+This command can toggle boolean options for the duration of a session.
+
** Calc
+++
diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
index 38b6ec984ab..270d9b44908 100644
--- a/lisp/cus-edit.el
+++ b/lisp/cus-edit.el
@@ -1227,6 +1227,40 @@ customize-option
(unless (eq symbol basevar)
(message "`%s' is an alias for `%s'" symbol basevar))))
+;;;###autoload
+(defun customize-toggle-option (symbol)
+ "Toggle the value of boolean option SYMBOL for this session."
+ (interactive (let ((prompt "Toggle boolean option: ") opts)
+ (mapatoms
+ (lambda (sym)
+ (when (eq (get sym 'custom-type) 'boolean)
+ (push sym opts))))
+ (list (intern (completing-read prompt opts)))))
+ (let* ((setter (or (get symbol 'custom-set) #'set-default))
+ (getter (or (get symbol 'custom-get) #'symbol-value))
+ (value (condition-case nil
+ (funcall getter symbol)
+ (void-variable (error "`%s' is not bound" symbol))))
+ (type (get symbol 'custom-type)))
+ (cond
+ ((eq type 'boolean))
+ ((and (null type)
+ (yes-or-no-p
+ (format "`%s' doesn't have a type, and has the value %S. \
+Proceed to toggle?" symbol value))))
+ ((yes-or-no-p
+ (format "`%s' is of type %s, and has the value %S. \
+Proceed to toggle?"
+ symbol type value)))
+ ((error "Abort toggling of option `%s'" symbol)))
+ (message "%s user options `%s'."
+ (if (funcall setter symbol (not value))
+ "Enabled" "Disabled")
+ symbol)))
+
+;;;###autoload
+(defalias 'toggle-option #'customize-toggle-option)
+
;;;###autoload
(defalias 'customize-variable-other-window 'customize-option-other-window)
--
2.43.0
next prev parent reply other threads:[~2024-02-13 0:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 17:32 bug#69079: [PATCH] Add 'customize-toggle-option' command Philip Kaludercic
2024-02-12 17:47 ` Eli Zaretskii
2024-02-12 18:41 ` Drew Adams
2024-02-12 18:56 ` Philip Kaludercic
2024-02-12 19:32 ` Eli Zaretskii
2024-02-13 0:14 ` Philip Kaludercic [this message]
2024-02-13 12:40 ` Eli Zaretskii
2024-02-13 12:46 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-13 20:09 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0hh1aq9.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=69079@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.