From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69079: [PATCH] Add 'customize-toggle-option' command Date: Tue, 13 Feb 2024 14:40:49 +0200 Message-ID: <864jecr0z2.fsf@gnu.org> References: <87frxx37wq.fsf@posteo.net> <86plx1r2uq.fsf@gnu.org> <87le7p1pg8.fsf@posteo.net> <86frxxqxzw.fsf@gnu.org> <87r0hh1aq9.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20307"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69079@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 13 13:41:51 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZs6h-00054v-90 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Feb 2024 13:41:51 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZs6c-0002SD-HV; Tue, 13 Feb 2024 07:41:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZs6b-0002Rf-2d for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 07:41:45 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZs6a-0001e6-Pj for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 07:41:44 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZs6s-0004bl-56 for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 07:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Feb 2024 12:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69079 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69079-submit@debbugs.gnu.org id=B69079.170782807817641 (code B ref 69079); Tue, 13 Feb 2024 12:42:02 +0000 Original-Received: (at 69079) by debbugs.gnu.org; 13 Feb 2024 12:41:18 +0000 Original-Received: from localhost ([127.0.0.1]:42784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZs6A-0004aT-7w for submit@debbugs.gnu.org; Tue, 13 Feb 2024 07:41:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZs67-0004aE-Ho for 69079@debbugs.gnu.org; Tue, 13 Feb 2024 07:41:17 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZs5k-0001RO-HF; Tue, 13 Feb 2024 07:40:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bBn4Dl8AjhAhuajkapYyS7M9qdpS9IFLRRMRBk4+Br4=; b=MmzMRrsCD+ky vZYLvwzWEIFiwr7v/22XECOfk1Bd4Ac9T3LVQIfDJoTcspoY3uuX9kY6/giSx5HRv2GThGE0paQe6 O5hK70HsldcAkU0tnKlDdvdhTXrjgNEqvxfj9AcbpBVwvPl0I7kN4zn25qdrXMddGNSYSr93T8OEP 5/vB26R8bqLtT9sHGZZaP6GlOrl9Y5Rir9r1NrUxh2M5NFpyJ0WHm3p9Wjek44z1aPr/41qX767QZ 0sGWIKbRaExMLkQe/ctfh+sit0c/1KDS3E0h9LVd8EuHRgkBNg49lRjbMZqOgPW8fqZaWRvMbMz8C EWheMNBkhPe+A2va4RMDEA==; In-Reply-To: <87r0hh1aq9.fsf@posteo.net> (message from Philip Kaludercic on Tue, 13 Feb 2024 00:14:38 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279959 Archived-At: > From: Philip Kaludercic > Cc: 69079@debbugs.gnu.org > Date: Tue, 13 Feb 2024 00:14:38 +0000 > > >> My assumption was that the command would only be invoked interactivly, > >> so I can either make that explicit with an `interactive-only' or repeat > >> the check. What do you think would be better? > > > > I think an explicit test is better, since then we get to display a > > user-friendly error message, instead of relying on Lisp errors to > > explain themselves. > > > > Btw, are you sure that the users can never succeed in inputting a > > non-boolean option with the way you prompt them? > > No, that was not ensured, and I think it is better not to. I have > adjusted the patch to check and prompt the user if the user option is > non-boolean, in case they know what they are doing. WDYT? LGTM, although I haven't tried to actually use the code. Thanks.