From: Eli Zaretskii <eliz@gnu.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 69079@debbugs.gnu.org
Subject: bug#69079: [PATCH] Add 'customize-toggle-option' command
Date: Mon, 12 Feb 2024 19:47:57 +0200 [thread overview]
Message-ID: <86plx1r2uq.fsf@gnu.org> (raw)
In-Reply-To: <87frxx37wq.fsf@posteo.net> (message from Philip Kaludercic on Mon, 12 Feb 2024 17:32:37 +0000)
> From: Philip Kaludercic <philipk@posteo.net>
> Date: Mon, 12 Feb 2024 17:32:37 +0000
>
> +;;;###autoload
> +(defun customize-toggle-option (opt)
> + "Toggle the value of boolean option OPT for this session."
> + (interactive (let (opts)
> + (mapatoms
> + (lambda (sym)
> + (when (eq (get sym 'custom-type) 'boolean)
> + (push sym opts))))
> + (list (intern (completing-read "Option: " opts)))))
> + (message "%s user options '%s'."
> + (if (funcall (or (get opt 'custom-set) #'set-default)
> + opt (not (funcall (or (get opt 'custom-get)
> + #'symbol-value)
> + opt)))
> + "Enabled" "Disabled")
> + opt))
Shouldn't this have some validation? what if the argument OPT is not a
boolean?
And the prompt should IMO say "Toggle boolean option: ".
next prev parent reply other threads:[~2024-02-12 17:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 17:32 bug#69079: [PATCH] Add 'customize-toggle-option' command Philip Kaludercic
2024-02-12 17:47 ` Eli Zaretskii [this message]
2024-02-12 18:41 ` Drew Adams
2024-02-12 18:56 ` Philip Kaludercic
2024-02-12 19:32 ` Eli Zaretskii
2024-02-13 0:14 ` Philip Kaludercic
2024-02-13 12:40 ` Eli Zaretskii
2024-02-13 12:46 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-13 20:09 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86plx1r2uq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=69079@debbugs.gnu.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.