all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
To: Theodor Thornhill <theo@thornhill.no>, 59833@debbugs.gnu.org
Cc: Randy Taylor <dev@rjt.dev>, Yuan Fu <casouri@gmail.com>,
	jostein@kjonigsen.net
Subject: bug#59833: 29.0.60; json-ts-mode fontifies everything as string
Date: Mon, 5 Dec 2022 12:53:01 +0100	[thread overview]
Message-ID: <07c73653-2983-519a-ea8b-8d955690304f@secure.kjonigsen.net> (raw)
In-Reply-To: <87o7sidqxf.fsf@thornhill.no>

Yeah. That works for me.

I tried making a similar patch, but I guess I was trying to overspecify, 
rather than just shortcutting the selection. Nice job!

--
Jostein


jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no <https://jostein.kjønigsen.no>
On 05.12.2022 12:35, Theodor Thornhill wrote:
> Theodor Thornhill <theo@thornhill.no> writes:
>
>> Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:
>>
>>> Hey everyone.
>>>
>>> When opening a JSON-file in a build from emacs git emacs-29
>>> release-branch, Emacs still defaults to json-mode.
>>>
>>> Fontification in json-mode looks correct and proper.
>>>
>>> When trying to insteas use json-ts-mode, literally everything is
>>> fontified as strings.
>>>
>>> When I change the code to disable the string-fontification rule, this
>>> yields a buffer where everything is fontified using default-face. That
>>> is, no other fontification is taking place.
>>>
>>> Have this mode really been tested? Should it be working? Or is there an
>>> error on my end?
>>>
>>> Could someone else please give json-ts-mode a try?
>>>
>> Yeah, you are correct.  It seems we've had a regression in this commit,
>> 0ed313642227afdeccf48057eea458edca9d2962.
>>
>> I believe this is the offending commit - what do you think, Randy?
>>
>> Specifically the lhs should be fontified differently than the rhs, so
>> not everything is a string.
>>
>> Do you want to do that, Randy, or should I?
>>
>> Theo
> Can you test this patch, Jostein?
>
> Theo
>





  reply	other threads:[~2022-12-05 11:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-05 10:40 bug#59833: 29.0.60; json-ts-mode fontifies everything as string Jostein Kjønigsen
2022-12-05 11:24 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 11:35   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 11:53     ` Jostein Kjønigsen [this message]
2022-12-05 12:06       ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 13:52   ` Randy Taylor
2022-12-05 13:58     ` Randy Taylor
2022-12-05 14:12       ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 14:42         ` Randy Taylor
2022-12-05 14:52           ` Jostein Kjønigsen
2022-12-05 15:00             ` Eli Zaretskii
2022-12-05 15:01             ` Randy Taylor
2022-12-05 15:03             ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 15:35               ` Randy Taylor
2022-12-05 15:37                 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 19:57                   ` Yuan Fu
2022-12-05 20:14                     ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 20:19                       ` Randy Taylor
2022-12-05 20:22                         ` Yuan Fu
2022-12-05 20:38                           ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07c73653-2983-519a-ea8b-8d955690304f@secure.kjonigsen.net \
    --to=jostein@secure.kjonigsen.net \
    --cc=59833@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=dev@rjt.dev \
    --cc=jostein@kjonigsen.net \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.