From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#59833: 29.0.60; json-ts-mode fontifies everything as string Date: Mon, 5 Dec 2022 12:53:01 +0100 Message-ID: <07c73653-2983-519a-ea8b-8d955690304f@secure.kjonigsen.net> References: <87sfhudrfu.fsf@thornhill.no> <87o7sidqxf.fsf@thornhill.no> Reply-To: jostein@kjonigsen.net Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24151"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Cc: Randy Taylor , Yuan Fu , jostein@kjonigsen.net To: Theodor Thornhill , 59833@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 05 12:54:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2A36-0005xU-Om for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Dec 2022 12:54:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2A2w-0004Gf-2W; Mon, 05 Dec 2022 06:54:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2A2t-0004GS-0v for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 06:54:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2A2s-0001xh-Pk for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 06:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2A2s-0003rM-El for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 06:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Dec 2022 11:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59833 X-GNU-PR-Package: emacs Original-Received: via spool by 59833-submit@debbugs.gnu.org id=B59833.167024120414827 (code B ref 59833); Mon, 05 Dec 2022 11:54:02 +0000 Original-Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 11:53:24 +0000 Original-Received: from localhost ([127.0.0.1]:35569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2A2F-0003r5-Pq for submit@debbugs.gnu.org; Mon, 05 Dec 2022 06:53:24 -0500 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:53553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2A2A-0003qy-Jy for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 06:53:22 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 53CC65C00B2; Mon, 5 Dec 2022 06:53:08 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 05 Dec 2022 06:53:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm3; t=1670241188; x=1670327588; bh=Fn Q6DsPLcgekIfodyj5d5Wl9ts6SGofiXgytOdKMVzI=; b=c/k4yR+ik3+njD+qxE lvWQyM5C0FCh1N0IFj8DLPDTLK8qMqaAtDqZCxkAlt6E24j/ZF4cbcXaHqDsW+7w xlezQB+2HFgQQ2/rVJb+d5ztVwBY6gqqbvda77a6zfL70yhKqJ8Y1mL3oYh/nkbB Ar7VtOcYlZ4Qz2y5/jcPED90wBVxD4/CENp0t/6RCTbFMciNJACoTJ45PPm3snU3 iZq5ghYSdD4t3IHLvbzxdQc2JbIRxnR5cXABNieMh5QjXiOqq/pXey5OMXWTHyoz dT5pOBfEsevjNlFB1v7gk/As/4dpr2LkP7WP3gVbUvqSqKaDmJIFgBZiH/AFv+tI Me1w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1670241188; x=1670327588; bh=FnQ6DsPLcgekIfodyj5d5Wl9ts6SGofiXgy tOdKMVzI=; b=cMM7e/zQxJj5qiz+Mx4gB6YsHXBJNlPqdw6Zc2pCH2gxopsTour CuAXS/kTM2BnZn+/a+iAOi1Ov9ZmRudXsQCZlr50Bk+ZzTUYUUVrsFec6X1+ZlaR lJwpBR3Lcue+Drh+ANjAx+ahb4FQsKtI2U7kxXp7daZGl5IwZsVwYgA9fgja8nCS ATkVliWskSAeAlOU7YThF5RwD663YYWCVfMghly274mSCINP5lVATmbouY55WWol i48CvOvcuORxH6R/4lHLmjfj8esjEkyDjkMT5M8w0oBXUkcFnOVANghq0GnqY20x u/qIPhhzbQWhPx6uEGDdBlIPW1LeboEbNmw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeggdefgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfghruffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpefhgeefgfevjeefveegleevffdt gfekfffhjeehgfevteffhfffkedtueejudehheenucffohhmrghinhepkhhjnhhighhsvg hnrdhnohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Dec 2022 06:53:03 -0500 (EST) Content-Language: nb-NO In-Reply-To: <87o7sidqxf.fsf@thornhill.no> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250010 Archived-At: Yeah. That works for me. I tried making a similar patch, but I guess I was trying to overspecify, rather than just shortcutting the selection. Nice job! -- Jostein jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no On 05.12.2022 12:35, Theodor Thornhill wrote: > Theodor Thornhill writes: > >> Jostein Kjønigsen writes: >> >>> Hey everyone. >>> >>> When opening a JSON-file in a build from emacs git emacs-29 >>> release-branch, Emacs still defaults to json-mode. >>> >>> Fontification in json-mode looks correct and proper. >>> >>> When trying to insteas use json-ts-mode, literally everything is >>> fontified as strings. >>> >>> When I change the code to disable the string-fontification rule, this >>> yields a buffer where everything is fontified using default-face. That >>> is, no other fontification is taking place. >>> >>> Have this mode really been tested? Should it be working? Or is there an >>> error on my end? >>> >>> Could someone else please give json-ts-mode a try? >>> >> Yeah, you are correct. It seems we've had a regression in this commit, >> 0ed313642227afdeccf48057eea458edca9d2962. >> >> I believe this is the offending commit - what do you think, Randy? >> >> Specifically the lhs should be fontified differently than the rhs, so >> not everything is a string. >> >> Do you want to do that, Randy, or should I? >> >> Theo > Can you test this patch, Jostein? > > Theo >