From: "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
To: Randy Taylor <dev@rjt.dev>, Theodor Thornhill <theo@thornhill.no>
Cc: Yuan Fu <casouri@gmail.com>,
59833@debbugs.gnu.org, jostein@kjonigsen.net
Subject: bug#59833: 29.0.60; json-ts-mode fontifies everything as string
Date: Mon, 5 Dec 2022 15:52:17 +0100 [thread overview]
Message-ID: <3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net> (raw)
In-Reply-To: <BPRmJYgr6L_VCd6CiqsamX8fMCw-z9OJl3xJpJ1_sZaCQvGTqHxMeF-Fuaa6FEaHoHqxxjBheWtZqWTRxvcwJZyqW_bIE4oI2Dzkzgo01Tg=@rjt.dev>
On 05.12.2022 15:42, Randy Taylor wrote:
>
> Thanks, I meant just the treesit-font-lock-feature-list variable :) (so moving pair before string).
>
> Having the font-lock settings alphabetized too is great, but I remember running into some highlighting issues depending on the order of things.
> For example, since error is above number, the number face will not be highlighted as error when an error occurs.
>
> Try:
> {
> "test": 2
> }
>
> and remove the colon. Before your patch, the entire line is red. After, only "test" is red.
>
> So in general, I think we should stick all :overrides at the bottom of that list (with error being the ultimate one), and keep everything above and below alphabetized, but separately, which is how I organized json-ts-mode.
Good observation. Agreed.
>
> Are you guys talking about the json-mode package? Jostein mentioned "Emacs still defaults to json-mode", but when I open a JSON file I get js-json-mode, which is what I assumed he meant. js-json-mode is what I was trying to match in json-ts-mode.
I've never heard of js-json-mode until today. I always use json-mode
(which AFAIK) is still the default for json-files, unless overridden in
your own .emacs setup.
I can see that in Emacs git right now, json-ts-mode behaves closely to
js-json-mode. I honestly expected it to match the Emacs-default
json-mode though, and found the current highlighting ... somewhat
unexpected.
IMO, yes the keys are technically speaking strings, but the are
predominantly and semantically keys, and IMO should be highlighted as
such. Just like json-mode does.
I realise this is somewhat subjective and preferential, but as far as my
preference goes, I clearly prefer json-mode over js-json-mode, and as
such also prefer the current patch-sets for json-ts-mode which Theo has
submitted.
(On my part we can avoid side-tracking related to why there are multiple
json-modes, unless has a deep need to contextualize these changes
related to those ;) )
--
Jostein
next prev parent reply other threads:[~2022-12-05 14:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 10:40 bug#59833: 29.0.60; json-ts-mode fontifies everything as string Jostein Kjønigsen
2022-12-05 11:24 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 11:35 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 11:53 ` Jostein Kjønigsen
2022-12-05 12:06 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 13:52 ` Randy Taylor
2022-12-05 13:58 ` Randy Taylor
2022-12-05 14:12 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 14:42 ` Randy Taylor
2022-12-05 14:52 ` Jostein Kjønigsen [this message]
2022-12-05 15:00 ` Eli Zaretskii
2022-12-05 15:01 ` Randy Taylor
2022-12-05 15:03 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 15:35 ` Randy Taylor
2022-12-05 15:37 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 19:57 ` Yuan Fu
2022-12-05 20:14 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 20:19 ` Randy Taylor
2022-12-05 20:22 ` Yuan Fu
2022-12-05 20:38 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net \
--to=jostein@secure.kjonigsen.net \
--cc=59833@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dev@rjt.dev \
--cc=jostein@kjonigsen.net \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.