all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Randy Taylor <dev@rjt.dev>
To: Theodor Thornhill <theo@thornhill.no>
Cc: "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>,
	"Yuan Fu" <casouri@gmail.com>,
	59833@debbugs.gnu.org, jostein@kjonigsen.net
Subject: bug#59833: 29.0.60; json-ts-mode fontifies everything as string
Date: Mon, 05 Dec 2022 20:19:00 +0000	[thread overview]
Message-ID: <aQA0pNlSA_soXEuWsIIv3uvEPFIuV5NkzgT2or7HVT6U45nqIfgoJSBuAkaduAFa1RKx5_TOdJEtkwnFmc47r_IH6Ll2MFKf8erRdnT4_Ss=@rjt.dev> (raw)
In-Reply-To: <6344E557-688E-44C5-BF84-CA88999BAF4E@thornhill.no>

On Monday, December 5th, 2022 at 15:14, Theodor Thornhill <theo@thornhill.no> wrote:
> 
> 
> On 5 December 2022 20:57:55 CET, Yuan Fu casouri@gmail.com wrote:
> 
> > > On Dec 5, 2022, at 7:37 AM, Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors bug-gnu-emacs@gnu.org wrote:
> > > 
> > > On 5 December 2022 16:35:12 CET, Randy Taylor dev@rjt.dev wrote:
> > > 
> > > > On Monday, December 5th, 2022 at 10:03, Theodor Thornhill theo@thornhill.no wrote:
> > > > 
> > > > > Yeah js-json-mode is a lot simpler, and is imo too simple. The json-mode
> > > > > is not infact default in emacs, but there are two, one in melpa and one
> > > > > in elpa, IIRC.
> > > > > 
> > > > > Anyway, last patch for now - are you both satisfied with this one?
> > > > > 
> > > > > Theo
> > > > 
> > > > It's perfect! Sorry for all the trouble :D.
> > > 
> > > No problem :)
> > > 
> > > Yuan, will you commit this one?
> > 
> > Yeah. IIUC :override t is not necessary for pair, right? If so, I’ll apply the patch and remove the :override, is that OK?
> > 
> > Yuan
> 
> 
> Please test it first, but sure! We want it to not be string face at least :)
> 
> Theo

It's necessary, since string comes first and pair needs to override it (just tested).





  reply	other threads:[~2022-12-05 20:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-05 10:40 bug#59833: 29.0.60; json-ts-mode fontifies everything as string Jostein Kjønigsen
2022-12-05 11:24 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 11:35   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 11:53     ` Jostein Kjønigsen
2022-12-05 12:06       ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 13:52   ` Randy Taylor
2022-12-05 13:58     ` Randy Taylor
2022-12-05 14:12       ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 14:42         ` Randy Taylor
2022-12-05 14:52           ` Jostein Kjønigsen
2022-12-05 15:00             ` Eli Zaretskii
2022-12-05 15:01             ` Randy Taylor
2022-12-05 15:03             ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 15:35               ` Randy Taylor
2022-12-05 15:37                 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 19:57                   ` Yuan Fu
2022-12-05 20:14                     ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05 20:19                       ` Randy Taylor [this message]
2022-12-05 20:22                         ` Yuan Fu
2022-12-05 20:38                           ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='aQA0pNlSA_soXEuWsIIv3uvEPFIuV5NkzgT2or7HVT6U45nqIfgoJSBuAkaduAFa1RKx5_TOdJEtkwnFmc47r_IH6Ll2MFKf8erRdnT4_Ss=@rjt.dev' \
    --to=dev@rjt.dev \
    --cc=59833@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=jostein@kjonigsen.net \
    --cc=jostein@secure.kjonigsen.net \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.