From: Philip Kaludercic <philipk@posteo.net>
To: Joseph Turner <joseph@breatheoutbreathe.in>
Cc: help-gnu-emacs@gnu.org
Subject: Re: package-vc-install fails to build docs
Date: Mon, 24 Apr 2023 05:54:39 +0000 [thread overview]
Message-ID: <87cz3tn7ts.fsf@posteo.net> (raw)
In-Reply-To: <87354qe44v.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sun, 23 Apr 2023 13:20:29 -0700")
Joseph Turner <joseph@breatheoutbreathe.in> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>> Joseph Turner <joseph@breatheoutbreathe.in> writes:
>>
>>> What would be the first steps to support :make in package-vc?
>>
>> If you are interested in working on this, I would take a look at
>> `package-vc--unpack-1' which would probably be the best place for that.
>
> Thank you. Yes, I am interested in working on this.
Great!
>>> How shall we pass :doc and :make values from package-vc-install down to
>>> package-vc--build-documentation?
>>>
>>> Do we want to refactor package-vc-unpack-1 so that it accepts a pkg-spec
>>> argument? Or maybe add :doc an :make keys to the pkg-desc plist?
>>
>> :doc is passed via an argument, and :make would have to be handled
>> before.
>
> Okay!
>
>>> How about yes-or-no-p by default, with an customization option to
>>> automatically trust specs from a trusted package archive?
>>
>> The latter should work fine, but the first would only be possible in
>> interactive usage.
>
> Got it.
>
> I'd like to look at the ELPA code for handling :make. I tried grepping
> for ":make" in the Emacs and ELPA repos, but to no avail.
You have to look at elpa-admin.el, the "reference interpretation" for
how package specifications are supposed to work. It is located on a
separate branch in elpa.git (so that it can be shared between elpa.git
and nongnu.git).
https://git.savannah.gnu.org/cgit/emacs/elpa.git/tree/elpa-admin.el?h=elpa-admin
> Mind pointing me in the right direction?
Ping me if you need anything else, and submit a bug report with a patch
as soon as you have something workable. Add a
X-Debbugs-CC: Philip Kaludercic <philipk@posteo.net>
header so that I get notified as well.
> Best,
>
> Joseph
next prev parent reply other threads:[~2023-04-24 5:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-22 5:34 package-vc-install fails to build docs Joseph Turner
2023-04-22 6:07 ` Ruijie Yu via Users list for the GNU Emacs text editor
2023-04-22 7:27 ` Philip Kaludercic
2023-04-22 22:56 ` Joseph Turner
2023-04-23 12:37 ` Philip Kaludercic
2023-04-23 16:54 ` Joseph Turner
2023-04-23 18:36 ` Philip Kaludercic
2023-04-23 20:20 ` Joseph Turner
2023-04-24 5:54 ` Philip Kaludercic [this message]
2023-04-28 19:42 ` Joseph Turner
2023-04-28 21:17 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz3tn7ts.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=help-gnu-emacs@gnu.org \
--cc=joseph@breatheoutbreathe.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).