From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.help Subject: Re: package-vc-install fails to build docs Date: Mon, 24 Apr 2023 05:54:39 +0000 Message-ID: <87cz3tn7ts.fsf@posteo.net> References: <87a5z0sc3r.fsf@breatheoutbreathe.in> <871qkcl6kq.fsf@posteo.net> <877cu3o6ld.fsf@breatheoutbreathe.in> <877cu293l9.fsf@posteo.net> <87pm7uedfa.fsf@breatheoutbreathe.in> <87pm7u1m44.fsf@posteo.net> <87354qe44v.fsf@breatheoutbreathe.in> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18207"; mail-complaints-to="usenet@ciao.gmane.io" Cc: help-gnu-emacs@gnu.org To: Joseph Turner Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 24 07:54:37 2023 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pqp9o-0004ZQ-Tc for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 24 Apr 2023 07:54:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqp9Z-0004Bx-8z; Mon, 24 Apr 2023 01:54:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqp9R-0003w4-1q for help-gnu-emacs@gnu.org; Mon, 24 Apr 2023 01:54:14 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqp9N-0007zz-6a for help-gnu-emacs@gnu.org; Mon, 24 Apr 2023 01:54:12 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 2B29B240119 for ; Mon, 24 Apr 2023 07:54:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1682315647; bh=rYNY6PrGFJrvkFrBhKtEXlnj+3Xhs6k0tlfZUyXaU8s=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=p7lZRXeft9YCGfyG95k/LQf1NIWrKhUHyyv2vFOPMXVZkvMPLIcwy6LZuelS0mkks t0hHYi1aDfOEoZ1iQuLls3HK1IJ5ctaolTL7UiG63F9Hj0tNdKsG363SrL9e0wKVk5 Li2RewilF2Ra8w0JCzEMTjE8N3dqATM7SXt4qwto/U+e7ZAq43Kc0DdFYHKXVNIdnN +DSeAl+40pka4asBgk6tt/y4KrvwX6P2lf6Tg8yZrnba5/1OEI8wTUOoOK0E5DAogG Niz71XBW51ptMVB8kTYyjfXY4QHZWBoKWKGrteuXHacKafbfmIX9AE5DwSc5AdAzv4 zCLPBjDAexhTw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q4Z7y49z2z9rxD; Mon, 24 Apr 2023 07:54:06 +0200 (CEST) In-Reply-To: <87354qe44v.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sun, 23 Apr 2023 13:20:29 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:143359 Archived-At: Joseph Turner writes: > Philip Kaludercic writes: >> Joseph Turner writes: >> >>> What would be the first steps to support :make in package-vc? >> >> If you are interested in working on this, I would take a look at >> `package-vc--unpack-1' which would probably be the best place for that. > > Thank you. Yes, I am interested in working on this. Great! >>> How shall we pass :doc and :make values from package-vc-install down to >>> package-vc--build-documentation? >>> >>> Do we want to refactor package-vc-unpack-1 so that it accepts a pkg-spec >>> argument? Or maybe add :doc an :make keys to the pkg-desc plist? >> >> :doc is passed via an argument, and :make would have to be handled >> before. > > Okay! > >>> How about yes-or-no-p by default, with an customization option to >>> automatically trust specs from a trusted package archive? >> >> The latter should work fine, but the first would only be possible in >> interactive usage. > > Got it. > > I'd like to look at the ELPA code for handling :make. I tried grepping > for ":make" in the Emacs and ELPA repos, but to no avail. You have to look at elpa-admin.el, the "reference interpretation" for how package specifications are supposed to work. It is located on a separate branch in elpa.git (so that it can be shared between elpa.git and nongnu.git). https://git.savannah.gnu.org/cgit/emacs/elpa.git/tree/elpa-admin.el?h=elpa-admin > Mind pointing me in the right direction? Ping me if you need anything else, and submit a bug report with a patch as soon as you have something workable. Add a X-Debbugs-CC: Philip Kaludercic header so that I get notified as well. > Best, > > Joseph