Re: package-vc-install fails to build docs

[Joseph Turner <joseph@breatheoutbreathe.in>]

Philip Kaludercic <philipk@posteo.net> writes:
> Joseph Turner <joseph@breatheoutbreathe.in> writes:
>
>> What would be the first steps to support :make in package-vc?
>
> If you are interested in working on this, I would take a look at
> `package-vc--unpack-1' which would probably be the best place for that.

Thank you. Yes, I am interested in working on this.

>> How shall we pass :doc and :make values from package-vc-install down to
>> package-vc--build-documentation?
>>
>> Do we want to refactor package-vc-unpack-1 so that it accepts a pkg-spec
>> argument? Or maybe add :doc an :make keys to the pkg-desc plist?
>
> :doc is passed via an argument, and :make would have to be handled
> before.

Okay!

>> How about yes-or-no-p by default, with an customization option to
>> automatically trust specs from a trusted package archive?
>
> The latter should work fine, but the first would only be possible in
> interactive usage.

Got it.

I'd like to look at the ELPA code for handling :make. I tried grepping
for ":make" in the Emacs and ELPA repos, but to no avail.

Mind pointing me in the right direction?

Best,

Joseph