From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner Newsgroups: gmane.emacs.help Subject: Re: package-vc-install fails to build docs Date: Sun, 23 Apr 2023 13:20:29 -0700 Message-ID: <87354qe44v.fsf@breatheoutbreathe.in> References: <87a5z0sc3r.fsf@breatheoutbreathe.in> <871qkcl6kq.fsf@posteo.net> <877cu3o6ld.fsf@breatheoutbreathe.in> <877cu293l9.fsf@posteo.net> <87pm7uedfa.fsf@breatheoutbreathe.in> <87pm7u1m44.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17601"; mail-complaints-to="usenet@ciao.gmane.io" Cc: help-gnu-emacs@gnu.org To: Philip Kaludercic Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 23 22:27:57 2023 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pqgJR-0004MC-55 for geh-help-gnu-emacs@m.gmane-mx.org; Sun, 23 Apr 2023 22:27:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqgIn-00083G-Sa; Sun, 23 Apr 2023 16:27:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqgId-00080m-8N for help-gnu-emacs@gnu.org; Sun, 23 Apr 2023 16:27:08 -0400 Original-Received: from out-36.mta0.migadu.com ([2001:41d0:1004:224b::24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqgIb-0000sF-9n for help-gnu-emacs@gnu.org; Sun, 23 Apr 2023 16:27:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1682281621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mvNzuiuKMIA6BVmq6XIg2WRxX+yDUOoytgm5WTyukxY=; b=MecWg4y8LpYPrgAs/+B4PbglTNJvdgiUZDuU3OFvuqSCIo1FDR68S+UMGu1d3fbRJVNx8l ah/lWKW+BSDoEJUJPWsBgy5spYc81noNFjo9Xv/U822T/KqNfu6f2IeGRykyJSMK9FZThm IC6QsLoF/eTpvsLhJpuTjCiAcfs9qY8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <87pm7u1m44.fsf@posteo.net> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::24; envelope-from=joseph@breatheoutbreathe.in; helo=out-36.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:143356 Archived-At: Philip Kaludercic writes: > Joseph Turner writes: > >> What would be the first steps to support :make in package-vc? > > If you are interested in working on this, I would take a look at > `package-vc--unpack-1' which would probably be the best place for that. Thank you. Yes, I am interested in working on this. >> How shall we pass :doc and :make values from package-vc-install down to >> package-vc--build-documentation? >> >> Do we want to refactor package-vc-unpack-1 so that it accepts a pkg-spec >> argument? Or maybe add :doc an :make keys to the pkg-desc plist? > > :doc is passed via an argument, and :make would have to be handled > before. Okay! >> How about yes-or-no-p by default, with an customization option to >> automatically trust specs from a trusted package archive? > > The latter should work fine, but the first would only be possible in > interactive usage. Got it. I'd like to look at the ELPA code for handling :make. I tried grepping for ":make" in the Emacs and ELPA repos, but to no avail. Mind pointing me in the right direction? Best, Joseph