Re: Changes in calendar/time-date.el

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Mon, Apr 04 2005, Lute Kamstra wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> --- message.el	30 Mar 2005 08:14:32 -0000	1.75
>> +++ message.el	4 Apr 2005 11:36:12 -0000
>> @@ -32,6 +32,8 @@
>>  
>>  (eval-when-compile
>>    (require 'cl)
>> +  (defvar parse-time-weekdays) ;; parse-time is required where necessary
>> +  (defvar parse-time-months)
>>    (defvar gnus-message-group-art)
>>    (defvar gnus-list-identifiers)) ; gnus-sum is required where necessary
>>  (require 'canlock)
>
> Can't you move this closer to the definition of message-make-date?
> It's only necessary to suppress compiler warnings for that function.

I put it inside the defun.

> Alternatively, you can use (with-no-warnings ...) around references to
> these variables.

`with-no-warnings' isn't available in Emacs 21.

>> --- nnimap.el	18 Mar 2005 02:49:57 -0000	1.23
>> +++ nnimap.el	4 Apr 2005 11:36:12 -0000
>> @@ -69,6 +69,8 @@
>>  (require 'gnus-range)
>>  (require 'gnus-start)
>>  (require 'gnus-int)
>> + ;; Only for `parse-time-months' in `nnimap-date-days-ago':
>> +(require 'parse-time)
>>  
>>  (eval-when-compile (require 'cl))
>
> Why not put the require in the body of nnimap-date-days-ago?

Okay, then I also need to add a defvar:
 
 (defun nnimap-date-days-ago (daysago)
   "Return date, in format \"3-Aug-1998\", for DAYSAGO days ago."
+  (require 'parse-time)
+  (defvar parse-time-months)
   (let* ((time (nnimap-time-substract (current-time) (days-to-time daysago)))
 	 (date (format-time-string
 		(format "%%d-%s-%%Y"

I have committed the changes to Gnus v5-10 branch.  If anyone want to
handle the compiler differently, feel free to change it.

Bye, Reiner.