Re: Changes in calendar/time-date.el

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Thu, Mar 31 2005, Lute Kamstra wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> On Wed, Mar 30 2005, Katsumi Yamaoka wrote:
>>> There's no ChangeLog for the recent changes of time-date.el and
>>> I don't know who did it for what purpose, 
[...]
>> ,----[ lisp/ChangeLog ]
>> | 2005-03-23  Lute Kamstra  <lute@gnu.org>
>> | [...]
>> | 	* calendar/time-date.el: Add comment on time value formats.
>> | 	Don't require parse-time.
>> | 	(with-decoded-time-value): New macro.
>> | 	(encode-time-value): New function.
>> | 	(time-to-seconds, time-less-p, time-subtract, time-add): Use them.
>> | 	(days-to-time): Return a valid time value when arg is huge.
>> | 	(time-since): Use time-subtract.
>> | 	(time-to-number-of-days): Use time-to-seconds.
>> `----

I have added a ChangeLog in Gnus lisp/ChangeLog.

>>> but at least the byte compiler complains to me about some missing
>>> Lisp objects.  What should we do for that?
>>
>> Probably we need to add (require 'parse-time) to nnimap.el,
>> nnultimate.el and pop3.el.
[...]
> I removed (require 'parse-time) from time-date because it uses just
> parse-time-string, which is autoloaded.  Do I understand correctly my
> change uncovered some bugs in nnimap.el, nnultimate.el and pop3.el?  I
> already noticed (and fixed) this for message.el.  

Wouldn't it be better to put (require 'parse-time) at the beginning of
the file instead of inside `message-make-date'?

> I don't use nnimap.el, nnultimate.el or pop3.el so I didn't catch
> those.  I'm sorry for that.

I added (require 'parse-time) at the beginning of those files in Gnus
stable branch.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/