From: Lute Kamstra <Lute.Kamstra.lists@xs4all.nl>
Cc: emacs-devel@gnu.org, ding@gnus.org, Miles Bader <miles@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
"Kim F. Storm" <storm@cua.dk>
Subject: Re: Changes in calendar/time-date.el
Date: Tue, 05 Apr 2005 15:54:24 +0200 [thread overview]
Message-ID: <87br8tjpm7.fsf@xs4all.nl> (raw)
In-Reply-To: <v94qembgqs.fsf@marauder.physik.uni-ulm.de> (Reiner Steib's message of "Mon, 04 Apr 2005 19:20:59 +0200")
Reiner Steib <reinersteib+gmane@imap.cc> writes:
[...]
> I have committed the changes to Gnus v5-10 branch. If anyone want to
> handle the compiler differently, feel free to change it.
I'd prefer to handle it like in the patch below. If the function
message-make-date or nnimap-date-days-ago is called *very* often, then
a single (require 'parse-time) at top level may be better. But all
require does is a memq on features, which has typically a few hundred
members. I suspect that doesn't take too much time.
Lute.
Index: lisp/gnus/message.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/gnus/message.el,v
retrieving revision 1.76
diff -u -r1.76 message.el
--- lisp/gnus/message.el 5 Apr 2005 04:10:27 -0000 1.76
+++ lisp/gnus/message.el 5 Apr 2005 13:42:31 -0000
@@ -4564,12 +4564,11 @@
(when (re-search-forward ",+$" nil t)
(replace-match "" t t))))))
+(eval-when-compile (require 'parse-time))
(defun message-make-date (&optional now)
"Make a valid data header.
If NOW, use that time instead."
(require 'parse-time)
- (defvar parse-time-weekdays)
- (defvar parse-time-months)
(let* ((now (or now (current-time)))
(zone (nth 8 (decode-time now)))
(sign "+"))
Index: lisp/gnus/nnimap.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/gnus/nnimap.el,v
retrieving revision 1.24
diff -u -r1.24 nnimap.el
--- lisp/gnus/nnimap.el 5 Apr 2005 04:10:27 -0000 1.24
+++ lisp/gnus/nnimap.el 5 Apr 2005 13:42:33 -0000
@@ -1386,10 +1386,10 @@
(list (- ms 1) (+ (expt 2 16) ls))
(list ms ls))))
+(eval-when-compile (require 'parse-time))
(defun nnimap-date-days-ago (daysago)
"Return date, in format \"3-Aug-1998\", for DAYSAGO days ago."
(require 'parse-time)
- (defvar parse-time-months)
(let* ((time (nnimap-time-substract (current-time) (days-to-time daysago)))
(date (format-time-string
(format "%%d-%s-%%Y"
prev parent reply other threads:[~2005-04-05 13:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1DGYNu-00038g-00@quimby.gnus.org>
[not found] ` <yotly8c5jpi2.fsf@jpl.org>
2005-03-31 11:27 ` Changes in calendar/time-date.el (was: CVS update of gnus/lisp (4 files)) Reiner Steib
2005-03-31 12:20 ` Miles Bader
2005-03-31 12:58 ` Changes in calendar/time-date.el Lute Kamstra
2005-03-31 22:52 ` Miles Bader
2005-04-01 4:10 ` Richard Stallman
2005-04-04 10:25 ` Reiner Steib
2005-04-04 10:57 ` Lute Kamstra
2005-04-04 12:09 ` Reiner Steib
2005-04-04 12:52 ` Lute Kamstra
2005-04-04 17:20 ` Reiner Steib
2005-04-04 19:50 ` Stefan Monnier
2005-04-05 7:14 ` Kim F. Storm
2005-04-05 9:33 ` Miles Bader
2005-04-05 10:06 ` Kim F. Storm
2005-04-07 12:47 ` require inside functions. (was: Changes in calendar/time-date.el) Lute Kamstra
2005-04-07 21:45 ` Kim F. Storm
2005-04-08 0:12 ` require inside functions Miles Bader
2005-04-08 0:45 ` Stefan Monnier
2005-04-08 2:09 ` Miles Bader
2005-04-08 0:21 ` Stefan Monnier
2005-04-08 3:22 ` require inside functions. (was: Changes in calendar/time-date.el) Richard Stallman
2005-04-08 8:12 ` Kim F. Storm
2005-04-09 3:38 ` require inside functions. (was: Changes in Richard Stallman
2005-04-09 9:30 ` require inside functions Lute Kamstra
2005-04-10 1:55 ` Richard Stallman
2005-04-13 9:11 ` Lute Kamstra
2005-04-15 2:44 ` Richard Stallman
2005-04-15 9:23 ` Lute Kamstra
2005-04-08 8:16 ` David Kastrup
2005-04-05 13:54 ` Lute Kamstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87br8tjpm7.fsf@xs4all.nl \
--to=lute.kamstra.lists@xs4all.nl \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=miles@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).