From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general,gmane.emacs.devel Subject: Re: Changes in calendar/time-date.el Date: Mon, 04 Apr 2005 19:20:59 +0200 Message-ID: References: <871x9w9dkn.fsf@xs4all.nl> <87mzsezu5f.fsf@xs4all.nl> <87hdimzou0.fsf@xs4all.nl> Reply-To: Reiner Steib NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1112635616 17459 80.91.229.2 (4 Apr 2005 17:26:56 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 4 Apr 2005 17:26:56 +0000 (UTC) Cc: emacs-devel@gnu.org, ding@gnus.org, Miles Bader Original-X-From: ding-owner+M8614@lists.math.uh.edu Mon Apr 04 19:26:50 2005 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13] ident=mail) by ciao.gmane.org with esmtp (Exim 4.43) id 1DIVK6-0000sW-94 for ding-account@gmane.org; Mon, 04 Apr 2005 19:25:15 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1DIVGR-0003vV-00; Mon, 04 Apr 2005 12:21:27 -0500 Original-Received: from util2.math.uh.edu ([129.7.128.23]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1DIVGN-0003vQ-00 for ding@lists.math.uh.edu; Mon, 04 Apr 2005 12:21:23 -0500 Original-Received: from quimby.gnus.org ([80.91.224.244]) by util2.math.uh.edu with esmtp (Exim 4.30) id 1DIVGL-0002hS-4v for ding@lists.math.uh.edu; Mon, 04 Apr 2005 12:21:21 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.1]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1DIVGK-0000nJ-00 for ; Mon, 04 Apr 2005 19:21:20 +0200 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by mail.uni-ulm.de (8.13.3/8.13.3) with ESMTP id j34HKxAJ025494; Mon, 4 Apr 2005 19:20:59 +0200 (MEST) Original-Received: by bridgekeeper.physik.uni-ulm.de (Postfix, from userid 170) id F30B6101BE; Mon, 4 Apr 2005 19:20:59 +0200 (CEST) Original-To: Lute Kamstra In-Reply-To: <87hdimzou0.fsf@xs4all.nl> (Lute Kamstra's message of "Mon, 04 Apr 2005 14:52:23 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DCC-servers-Metrics: gemini 1049; Body=4 Fuz1=4 Fuz2=4 X-Spam-Score: -4.9 (----) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:60088 gmane.emacs.devel:35542 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:35542 On Mon, Apr 04 2005, Lute Kamstra wrote: > Reiner Steib writes: >> --- message.el 30 Mar 2005 08:14:32 -0000 1.75 >> +++ message.el 4 Apr 2005 11:36:12 -0000 >> @@ -32,6 +32,8 @@ >> >> (eval-when-compile >> (require 'cl) >> + (defvar parse-time-weekdays) ;; parse-time is required where necessary >> + (defvar parse-time-months) >> (defvar gnus-message-group-art) >> (defvar gnus-list-identifiers)) ; gnus-sum is required where necessary >> (require 'canlock) > > Can't you move this closer to the definition of message-make-date? > It's only necessary to suppress compiler warnings for that function. I put it inside the defun. > Alternatively, you can use (with-no-warnings ...) around references to > these variables. `with-no-warnings' isn't available in Emacs 21. >> --- nnimap.el 18 Mar 2005 02:49:57 -0000 1.23 >> +++ nnimap.el 4 Apr 2005 11:36:12 -0000 >> @@ -69,6 +69,8 @@ >> (require 'gnus-range) >> (require 'gnus-start) >> (require 'gnus-int) >> + ;; Only for `parse-time-months' in `nnimap-date-days-ago': >> +(require 'parse-time) >> >> (eval-when-compile (require 'cl)) > > Why not put the require in the body of nnimap-date-days-ago? Okay, then I also need to add a defvar: (defun nnimap-date-days-ago (daysago) "Return date, in format \"3-Aug-1998\", for DAYSAGO days ago." + (require 'parse-time) + (defvar parse-time-months) (let* ((time (nnimap-time-substract (current-time) (days-to-time daysago))) (date (format-time-string (format "%%d-%s-%%Y" I have committed the changes to Gnus v5-10 branch. If anyone want to handle the compiler differently, feel free to change it. Bye, Reiner.