From: Ulrich Mueller <ulm@gentoo.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-29 3c1693d08b0: Fix Elisp code injection vulnerability in emacsclient-mail.desktop
Date: Wed, 08 Mar 2023 08:15:48 +0100 [thread overview]
Message-ID: <ucz5jsogr@gentoo.org> (raw)
In-Reply-To: <87zg8onfob.fsf@yahoo.com> (Po Lu's message of "Wed, 08 Mar 2023 10:24:36 +0800")
>>>>> On Wed, 08 Mar 2023, Po Lu wrote:
> Ulrich Mueller <ulm@gentoo.org> writes:
>> Then the desktop file won't work, obviously. The problem is that
>> ${PARAMETER//PATTERN/STRING} substitution is not available in POSIX
>> parameter expansion. So with POSIX sh, an external program (e.g. sed)
>> would have to be called.
>>
>> The long term solution (suggested by Stefan Monnier) might be to add
>> a --funcall option to emacsclient. Then there would be no need for a
>> shell wrapper, in the first place.
>>
>> Should the Makefile skip installation of emacsclient-mail.desktop
>> when bash isn't available on the system?
> Could we install this change not on emacs-29, but on master?
> I don't think the problem it solves is severe, nor a regression from
> Emacs 28. It is rather a minor nusiance with certain URLs.
Seriously? It is a vulnerability that allows remote injection of
arbitrary Elisp code through a crafted "mailto" URI.
next prev parent reply other threads:[~2023-03-08 7:15 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167821009581.14664.5608674978571454819@vcs2.savannah.gnu.org>
[not found] ` <20230307172816.2D56BC13915@vcs2.savannah.gnu.org>
2023-03-08 0:27 ` emacs-29 3c1693d08b0: Fix Elisp code injection vulnerability in emacsclient-mail.desktop Po Lu
2023-03-08 2:14 ` Ulrich Mueller
2023-03-08 2:24 ` Po Lu
2023-03-08 7:15 ` Ulrich Mueller [this message]
2023-03-08 8:09 ` Po Lu
2023-03-08 8:32 ` Ulrich Mueller
2023-03-08 10:29 ` Po Lu
2023-03-08 10:39 ` Ulrich Mueller
2023-03-08 10:44 ` Robert Pluim
2023-03-08 11:08 ` Ulrich Mueller
2023-03-08 11:29 ` Ulrich Mueller
2023-03-08 11:47 ` Robert Pluim
2023-03-08 14:17 ` Eli Zaretskii
2023-03-08 15:47 ` Robert Pluim
2023-03-08 17:03 ` Jim Porter
2023-03-08 17:20 ` Robert Pluim
2023-03-08 17:41 ` Eli Zaretskii
2023-03-08 18:54 ` Jim Porter
2023-03-09 9:30 ` Robert Pluim
2023-03-09 10:22 ` Po Lu
2023-03-09 10:50 ` Robert Pluim
2023-03-09 18:36 ` Jim Porter
2023-03-08 11:44 ` Po Lu
2023-03-08 14:14 ` Eli Zaretskii
2023-03-09 0:50 ` Po Lu
2023-03-09 7:19 ` Eli Zaretskii
2023-03-09 7:25 ` Po Lu
2023-03-09 7:49 ` Manuel Giraud via Emacs development discussions.
2023-03-09 8:20 ` tomas
2023-03-08 10:58 ` Po Lu
2023-03-08 11:44 ` Ulrich Mueller
2023-03-08 14:13 ` Eli Zaretskii
2023-03-08 14:05 ` Eli Zaretskii
2023-03-08 10:37 ` Robert Pluim
2023-03-08 12:14 ` Ulrich Mueller
2023-03-08 15:49 ` Robert Pluim
2023-03-08 14:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ucz5jsogr@gentoo.org \
--to=ulm@gentoo.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).