From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ulrich Mueller Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 3c1693d08b0: Fix Elisp code injection vulnerability in emacsclient-mail.desktop Date: Wed, 08 Mar 2023 08:15:48 +0100 Message-ID: References: <167821009581.14664.5608674978571454819@vcs2.savannah.gnu.org> <20230307172816.2D56BC13915@vcs2.savannah.gnu.org> <877cvsozn5.fsf@yahoo.com> <87zg8onfob.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4855"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 08 08:16:45 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZo2W-00017J-Vm for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Mar 2023 08:16:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZo1t-0005Eo-IP; Wed, 08 Mar 2023 02:16:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZo1k-0005AU-Lf for emacs-devel@gnu.org; Wed, 08 Mar 2023 02:15:57 -0500 Original-Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pZo1i-0006iv-QP for emacs-devel@gnu.org; Wed, 08 Mar 2023 02:15:56 -0500 In-Reply-To: <87zg8onfob.fsf@yahoo.com> (Po Lu's message of "Wed, 08 Mar 2023 10:24:36 +0800") Received-SPF: pass client-ip=140.211.166.183; envelope-from=ulm@gentoo.org; helo=smtp.gentoo.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304109 Archived-At: >>>>> On Wed, 08 Mar 2023, Po Lu wrote: > Ulrich Mueller writes: >> Then the desktop file won't work, obviously. The problem is that >> ${PARAMETER//PATTERN/STRING} substitution is not available in POSIX >> parameter expansion. So with POSIX sh, an external program (e.g. sed) >> would have to be called. >> >> The long term solution (suggested by Stefan Monnier) might be to add >> a --funcall option to emacsclient. Then there would be no need for a >> shell wrapper, in the first place. >> >> Should the Makefile skip installation of emacsclient-mail.desktop >> when bash isn't available on the system? > Could we install this change not on emacs-29, but on master? > I don't think the problem it solves is severe, nor a regression from > Emacs 28. It is rather a minor nusiance with certain URLs. Seriously? It is a vulnerability that allows remote injection of arbitrary Elisp code through a crafted "mailto" URI.