unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Ulrich Mueller <ulm@gentoo.org>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-29 3c1693d08b0: Fix Elisp code injection vulnerability in emacsclient-mail.desktop
Date: Wed, 08 Mar 2023 18:58:47 +0800	[thread overview]
Message-ID: <871qlzo6fs.fsf@yahoo.com> (raw)
In-Reply-To: <usfefr0gr@gentoo.org> (Ulrich Mueller's message of "Wed, 08 Mar 2023 11:39:32 +0100")

Ulrich Mueller <ulm@gentoo.org> writes:

> Sorry, but I've installed this on emacs-29 with an explicit ack from
> both Eli and Stefan.

Why was this considered okay for emacs-29?

IMHO we should stop kow-towing to the information security people who
make a huge fuss over every single bug, especially bugs like this one
which only show up when you specifically try to trigger them.

Proprietary JavaScript routinely does things far more nasty and
malicious than a hyperlink that can be read before being clicked.

> An alternative solution would be to drop emacsclient-mail.desktop
> altogether, since this desktop file isn't part of any core
> functionality. It could be readded once emacsclient has gained a
> --funcall argument, so that arguments can be passed in a sane way.

Or perhaps Emacs 29 can forgo this change entirely.  Why would anyone
click a URL containing suspicious looking Lisp code, and who would
actually try to do nasty things with such URLs?

If you have to go out of your way to trigger a bug in a branch that is
supposed to be stable, then fixing it can wait.

Just my two cents.  Feel free to disregard them if you want, but keep in
mind it will result in many angry users.



  parent reply	other threads:[~2023-03-08 10:58 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <167821009581.14664.5608674978571454819@vcs2.savannah.gnu.org>
     [not found] ` <20230307172816.2D56BC13915@vcs2.savannah.gnu.org>
2023-03-08  0:27   ` emacs-29 3c1693d08b0: Fix Elisp code injection vulnerability in emacsclient-mail.desktop Po Lu
2023-03-08  2:14     ` Ulrich Mueller
2023-03-08  2:24       ` Po Lu
2023-03-08  7:15         ` Ulrich Mueller
2023-03-08  8:09           ` Po Lu
2023-03-08  8:32             ` Ulrich Mueller
2023-03-08 10:29               ` Po Lu
2023-03-08 10:39                 ` Ulrich Mueller
2023-03-08 10:44                   ` Robert Pluim
2023-03-08 11:08                     ` Ulrich Mueller
2023-03-08 11:29                       ` Ulrich Mueller
2023-03-08 11:47                         ` Robert Pluim
2023-03-08 14:17                           ` Eli Zaretskii
2023-03-08 15:47                             ` Robert Pluim
2023-03-08 17:03                             ` Jim Porter
2023-03-08 17:20                               ` Robert Pluim
2023-03-08 17:41                                 ` Eli Zaretskii
2023-03-08 18:54                                 ` Jim Porter
2023-03-09  9:30                                   ` Robert Pluim
2023-03-09 10:22                                     ` Po Lu
2023-03-09 10:50                                       ` Robert Pluim
2023-03-09 18:36                                       ` Jim Porter
2023-03-08 11:44                       ` Po Lu
2023-03-08 14:14                       ` Eli Zaretskii
2023-03-09  0:50                         ` Po Lu
2023-03-09  7:19                           ` Eli Zaretskii
2023-03-09  7:25                             ` Po Lu
2023-03-09  7:49                               ` Manuel Giraud via Emacs development discussions.
2023-03-09  8:20                             ` tomas
2023-03-08 10:58                   ` Po Lu [this message]
2023-03-08 11:44                     ` Ulrich Mueller
2023-03-08 14:13                     ` Eli Zaretskii
2023-03-08 14:05                   ` Eli Zaretskii
2023-03-08 10:37           ` Robert Pluim
2023-03-08 12:14             ` Ulrich Mueller
2023-03-08 15:49               ` Robert Pluim
2023-03-08 14:04             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qlzo6fs.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    --cc=ulm@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).