From: Robert Pluim <rpluim@gmail.com>
To: Jim Porter <jporterbugs@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
ulm@gentoo.org, luangruo@yahoo.com, emacs-devel@gnu.org
Subject: Re: emacs-29 3c1693d08b0: Fix Elisp code injection vulnerability in emacsclient-mail.desktop
Date: Thu, 09 Mar 2023 10:30:14 +0100 [thread overview]
Message-ID: <87sfeenuft.fsf@gmail.com> (raw)
In-Reply-To: <560b874e-f67e-0b45-d489-8a45c4d8312d@gmail.com> (Jim Porter's message of "Wed, 8 Mar 2023 10:54:08 -0800")
>>>>> On Wed, 8 Mar 2023 10:54:08 -0800, Jim Porter <jporterbugs@gmail.com> said:
Jim> 'set-arg' is probably simple enough that we could expect users to
Jim> write it themselves. '--apply' is a bit tricky (for emacsclient at
Jim> least), since we'd need to properly escape strings. I guess the
Jim> complexity of doing this would depend on how we did the escaping
Jim> though.
Iʼm not sure what escaping is needed. We take each command line
argument and pass it to emacs wrapped in "" so itʼs treated as a
string.
Jim> For reference for this thread, the conclusion we came to in bug#57752
Jim> was an interface like this:
Jim> emacs --apply func1 arg1 arg2 -- --apply func2 arg3 arg4
Jim> (Ditto for emacsclient.)
Thatʼs not that easy to do with our current usage of getopt. For
emacsclient, OTOH, the following is pretty easy to support without any
changes to server.el
emacsclient --apply func arg1 arg2
since --apply can (ab)use --eval internally.
Robert
--
next prev parent reply other threads:[~2023-03-09 9:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167821009581.14664.5608674978571454819@vcs2.savannah.gnu.org>
[not found] ` <20230307172816.2D56BC13915@vcs2.savannah.gnu.org>
2023-03-08 0:27 ` emacs-29 3c1693d08b0: Fix Elisp code injection vulnerability in emacsclient-mail.desktop Po Lu
2023-03-08 2:14 ` Ulrich Mueller
2023-03-08 2:24 ` Po Lu
2023-03-08 7:15 ` Ulrich Mueller
2023-03-08 8:09 ` Po Lu
2023-03-08 8:32 ` Ulrich Mueller
2023-03-08 10:29 ` Po Lu
2023-03-08 10:39 ` Ulrich Mueller
2023-03-08 10:44 ` Robert Pluim
2023-03-08 11:08 ` Ulrich Mueller
2023-03-08 11:29 ` Ulrich Mueller
2023-03-08 11:47 ` Robert Pluim
2023-03-08 14:17 ` Eli Zaretskii
2023-03-08 15:47 ` Robert Pluim
2023-03-08 17:03 ` Jim Porter
2023-03-08 17:20 ` Robert Pluim
2023-03-08 17:41 ` Eli Zaretskii
2023-03-08 18:54 ` Jim Porter
2023-03-09 9:30 ` Robert Pluim [this message]
2023-03-09 10:22 ` Po Lu
2023-03-09 10:50 ` Robert Pluim
2023-03-09 18:36 ` Jim Porter
2023-03-08 11:44 ` Po Lu
2023-03-08 14:14 ` Eli Zaretskii
2023-03-09 0:50 ` Po Lu
2023-03-09 7:19 ` Eli Zaretskii
2023-03-09 7:25 ` Po Lu
2023-03-09 7:49 ` Manuel Giraud via Emacs development discussions.
2023-03-09 8:20 ` tomas
2023-03-08 10:58 ` Po Lu
2023-03-08 11:44 ` Ulrich Mueller
2023-03-08 14:13 ` Eli Zaretskii
2023-03-08 14:05 ` Eli Zaretskii
2023-03-08 10:37 ` Robert Pluim
2023-03-08 12:14 ` Ulrich Mueller
2023-03-08 15:49 ` Robert Pluim
2023-03-08 14:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfeenuft.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jporterbugs@gmail.com \
--cc=luangruo@yahoo.com \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).