unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: storm@cua.dk (Kim F. Storm)
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Problem with revert-buffer and overlays [was: Two minor problems with CUA rectangles]
Date: Sun, 27 Nov 2005 00:37:05 +0100	[thread overview]
Message-ID: <m3psonvv4u.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <43871059.9090705@gmx.at> (martin rudalics's message of "Fri, 25 Nov 2005 14:23:37 +0100")

martin rudalics <rudalics@gmx.at> writes:

> Suppose I have a TAB with a text-property that specifies a background
> color. [...]

I have installed a fix for this.  Thanks for noticing...


> M-x revert-buffer with an active rectangle in that buffer apparently
> deactivates the rectangle but overlays used for the rectangle are not
> removed.  C-l does not remove them either.

The problem for cua is that revert-buffer kills all local variables in
the buffer, so the list of overlays (which cua keeps in a local
variable) is no longer available to cua's post-command hook which
would otherwise have cleaned this up.

I don't really see how cua work around this, or force revert-buffer to
do that, as there are no hooks which a guaranteed to be called by
revert ... 


This seems to be a generic problem with revert-buffer, as other modes
may also have overlays in the buffer which should be removed by
revert-buffer.  It seems like it should unconditionally delete all
overlays in that buffer.

Perhaps things which kills all local variables should also kill all
overlays in the buffer.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

  reply	other threads:[~2005-11-26 23:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-25 13:23 Two minor problems with CUA rectangles martin rudalics
2005-11-26 23:37 ` Kim F. Storm [this message]
2005-11-27  3:28   ` Problem with revert-buffer and overlays [was: Two minor problems with CUA rectangles] Richard M. Stallman
2005-11-27 21:02     ` Problem with revert-buffer and overlays Kim F. Storm
2005-11-28  4:47       ` Richard M. Stallman
2005-11-28 10:17         ` martin rudalics
2005-11-28 12:38           ` Kim F. Storm
2005-11-28 21:00           ` Richard M. Stallman
2005-11-29  9:15             ` martin rudalics
2005-11-29 21:47               ` Richard M. Stallman
2005-11-30  9:52                 ` martin rudalics
2005-12-04 21:19                   ` Richard M. Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3psonvv4u.fsf@kfs-l.imdomain.dk \
    --to=storm@cua.dk \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).