From: storm@cua.dk (Kim F. Storm)
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: Problem with revert-buffer and overlays
Date: Mon, 28 Nov 2005 13:38:23 +0100 [thread overview]
Message-ID: <m3mzjphrr4.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <438AD957.4010005@gmx.at> (martin rudalics's message of "Mon, 28 Nov 2005 11:17:59 +0100")
martin rudalics <rudalics@gmx.at> writes:
> > This seems to be a generic problem with revert-buffer, as other modes
> > may also have overlays in the buffer which should be removed by
> > revert-buffer. It seems like it should unconditionally delete all
> > overlays in that buffer.
> >
> > Perhaps things which kills all local variables should also kill all
> > overlays in the buffer.
>
> > It should be done in revert-buffer, I think.
> > after-find-file is not the right place,
> > and normal-mode should NOT mess with overlays.
>
> Why not do this in kill-all-local-variables then?
>
> Although solving this problem is tricky in general. Consider two
> buffers A and B. A buffer-local variable in A may reference an overlay
> in buffer B. When A is reverted how remove the overlay in B?
This looks like a can of works best left alone for now.
>
> > BTW, I noticed that revert-buffer does not deactivate the mark.
> >
> > That seems like a bug, too.
>
> Deactivating the mark would have to be done by insert-file-contents if
> it finds out that the mark has been invalidated during reversion. I'd
> leave this alone until someone complains.
Ok with me. Still, I'll fix it for cua.
> In a similar way, I don't
> think it necessary to remove the CUA rectangle when a buffer is
> reverted.
It may not be necessary, but since most of the cua state is kept in
buffer local variables, that state is lost when you do revert-buffer,
so to keep the rectangle, cua must do "extra work" to ensure it is
still valid after revert-buffer. So it is simpler to remove it.
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
next prev parent reply other threads:[~2005-11-28 12:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-25 13:23 Two minor problems with CUA rectangles martin rudalics
2005-11-26 23:37 ` Problem with revert-buffer and overlays [was: Two minor problems with CUA rectangles] Kim F. Storm
2005-11-27 3:28 ` Richard M. Stallman
2005-11-27 21:02 ` Problem with revert-buffer and overlays Kim F. Storm
2005-11-28 4:47 ` Richard M. Stallman
2005-11-28 10:17 ` martin rudalics
2005-11-28 12:38 ` Kim F. Storm [this message]
2005-11-28 21:00 ` Richard M. Stallman
2005-11-29 9:15 ` martin rudalics
2005-11-29 21:47 ` Richard M. Stallman
2005-11-30 9:52 ` martin rudalics
2005-12-04 21:19 ` Richard M. Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3mzjphrr4.fsf@kfs-l.imdomain.dk \
--to=storm@cua.dk \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).