unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: storm@cua.dk (Kim F. Storm)
Cc: rudalics@gmx.at, emacs-devel@gnu.org
Subject: Re: Problem with revert-buffer and overlays
Date: Sun, 27 Nov 2005 22:02:39 +0100	[thread overview]
Message-ID: <m31x11953k.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <E1EgDDJ-0004Xu-B0@fencepost.gnu.org> (Richard M. Stallman's message of "Sat, 26 Nov 2005 22:28:29 -0500")

"Richard M. Stallman" <rms@gnu.org> writes:

>     This seems to be a generic problem with revert-buffer, as other modes
>     may also have overlays in the buffer which should be removed by
>     revert-buffer.  It seems like it should unconditionally delete all
>     overlays in that buffer.
>
> This seems plausible to me.  In general, one must expect those
> overlays to be relocated to garbage, so preserving them cannot work
> reliably.
>
> Would you like to do that?

I looked at the code, and it is not obvious to me where this should be done.
It could be done in one of: revert-buffer, after-find-file, normal-mode.

I think someone more familiar with revert-buffer should work on this.

BTW, I noticed that revert-buffer does not deactivate the mark.



In any case, I realized that I _can_ fix this in cua-mode by making the
local variable holding the overlays permanent-local.  Perhaps that would 
be safer this close to the release.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

  reply	other threads:[~2005-11-27 21:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-25 13:23 Two minor problems with CUA rectangles martin rudalics
2005-11-26 23:37 ` Problem with revert-buffer and overlays [was: Two minor problems with CUA rectangles] Kim F. Storm
2005-11-27  3:28   ` Richard M. Stallman
2005-11-27 21:02     ` Kim F. Storm [this message]
2005-11-28  4:47       ` Problem with revert-buffer and overlays Richard M. Stallman
2005-11-28 10:17         ` martin rudalics
2005-11-28 12:38           ` Kim F. Storm
2005-11-28 21:00           ` Richard M. Stallman
2005-11-29  9:15             ` martin rudalics
2005-11-29 21:47               ` Richard M. Stallman
2005-11-30  9:52                 ` martin rudalics
2005-12-04 21:19                   ` Richard M. Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m31x11953k.fsf@kfs-l.imdomain.dk \
    --to=storm@cua.dk \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).