Re: master de8cae30bcf: Add global minor mode 'global-completion-preview-mode'

Re: master de8cae30bcf: Add global minor mode 'global-completion-preview-mode'

[Arash Esbati]

Eshel Yaron via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:

> branch: master
> commit de8cae30bcf8283e4c3b069ccb8b75224659ac5c
> Author: Eshel Yaron <me@eshelyaron.com>
> Commit: Eshel Yaron <me@eshelyaron.com>
>
>     Add global minor mode 'global-completion-preview-mode'
>     
>     This is a global variant of 'completion-preview-mode'.
>     
>     * lisp/completion-preview.el (global-completion-preview-mode): New
>     global minor mode.
>     
>     * doc/emacs/programs.texi (Symbol Completion): Document it.
>     
>     * etc/NEWS: Announce it.  (Bug#70010)
> ---
>  doc/emacs/programs.texi    | 11 +++++++----
>  etc/NEWS                   |  2 ++
>  lisp/completion-preview.el |  4 ++++
>  3 files changed, 13 insertions(+), 4 deletions(-)
> [...]
> diff --git a/etc/NEWS b/etc/NEWS
> index 1204f58c5ca..775c8e02a95 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -1559,6 +1559,8 @@ sexp navigation more intuitive.
>  This minor mode shows you symbol completion suggestions as you type,
>  using an inline preview.  New user options in the 'completion-preview'
>  customization group control exactly when Emacs displays this preview.
> +'completion-preview-mode' is buffer-local, to enable it globally use
> +'global-completion-preview-mode'.
>  
>  ---
>  ** The highly accessible Modus themes collection has eight items.
> diff --git a/lisp/completion-preview.el b/lisp/completion-preview.el
> index e827da43a08..6abdfed51a3 100644
> --- a/lisp/completion-preview.el
> +++ b/lisp/completion-preview.el
> @@ -415,5 +415,9 @@ cycles backward."
>      (remove-hook 'post-command-hook #'completion-preview--post-command t)
>      (completion-preview-active-mode -1)))
>  
> +(define-globalized-minor-mode global-completion-preview-mode
> +  completion-preview-mode completion-preview-mode
> +  :predicate '((not minibuffer-mode special-mode) t))
> +

Hi Eshel,

in order to do 'M-x global-completion-preview-mode', shouldn't the above
be autoloaded?  In that case, the ";;;###autoload" cookie is missing, I
think.

Best, Arash

Re: master de8cae30bcf: Add global minor mode 'global-completion-preview-mode'

[Eshel Yaron]

Hello Arash,

Arash Esbati <arash@gnu.org> writes:

> Eshel Yaron via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
>

[...42 lines elided...]

>> +(define-globalized-minor-mode global-completion-preview-mode
>> +  completion-preview-mode completion-preview-mode
>> +  :predicate '((not minibuffer-mode special-mode) t))
>> +
>
> Hi Eshel,
>
> in order to do 'M-x global-completion-preview-mode', shouldn't the above
> be autoloaded?  In that case, the ";;;###autoload" cookie is missing, I
> think.

You're right, thanks for noticing.  It should be fixed in master now.


Cheers,

Eshel