From: Arash Esbati <arash@gnu.org>
To: emacs-devel@gnu.org
Cc: Eshel Yaron <me@eshelyaron.com>
Subject: Re: master de8cae30bcf: Add global minor mode 'global-completion-preview-mode'
Date: Wed, 03 Apr 2024 00:18:42 +0200 [thread overview]
Message-ID: <m2bk6r2yt9.fsf@macmutant.fritz.box> (raw)
In-Reply-To: <20240331073318.645A2C1FB50@vcs2.savannah.gnu.org> (Eshel Yaron via Mailing list for Emacs changes's message of "Sun, 31 Mar 2024 03:33:18 -0400 (EDT)")
Eshel Yaron via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
> branch: master
> commit de8cae30bcf8283e4c3b069ccb8b75224659ac5c
> Author: Eshel Yaron <me@eshelyaron.com>
> Commit: Eshel Yaron <me@eshelyaron.com>
>
> Add global minor mode 'global-completion-preview-mode'
>
> This is a global variant of 'completion-preview-mode'.
>
> * lisp/completion-preview.el (global-completion-preview-mode): New
> global minor mode.
>
> * doc/emacs/programs.texi (Symbol Completion): Document it.
>
> * etc/NEWS: Announce it. (Bug#70010)
> ---
> doc/emacs/programs.texi | 11 +++++++----
> etc/NEWS | 2 ++
> lisp/completion-preview.el | 4 ++++
> 3 files changed, 13 insertions(+), 4 deletions(-)
> [...]
> diff --git a/etc/NEWS b/etc/NEWS
> index 1204f58c5ca..775c8e02a95 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -1559,6 +1559,8 @@ sexp navigation more intuitive.
> This minor mode shows you symbol completion suggestions as you type,
> using an inline preview. New user options in the 'completion-preview'
> customization group control exactly when Emacs displays this preview.
> +'completion-preview-mode' is buffer-local, to enable it globally use
> +'global-completion-preview-mode'.
>
> ---
> ** The highly accessible Modus themes collection has eight items.
> diff --git a/lisp/completion-preview.el b/lisp/completion-preview.el
> index e827da43a08..6abdfed51a3 100644
> --- a/lisp/completion-preview.el
> +++ b/lisp/completion-preview.el
> @@ -415,5 +415,9 @@ cycles backward."
> (remove-hook 'post-command-hook #'completion-preview--post-command t)
> (completion-preview-active-mode -1)))
>
> +(define-globalized-minor-mode global-completion-preview-mode
> + completion-preview-mode completion-preview-mode
> + :predicate '((not minibuffer-mode special-mode) t))
> +
Hi Eshel,
in order to do 'M-x global-completion-preview-mode', shouldn't the above
be autoloaded? In that case, the ";;;###autoload" cookie is missing, I
think.
Best, Arash
next parent reply other threads:[~2024-04-02 22:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171187039810.994.12465478999484475234@vcs2.savannah.gnu.org>
[not found] ` <20240331073318.645A2C1FB50@vcs2.savannah.gnu.org>
2024-04-02 22:18 ` Arash Esbati [this message]
2024-04-03 6:43 ` master de8cae30bcf: Add global minor mode 'global-completion-preview-mode' Eshel Yaron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2bk6r2yt9.fsf@macmutant.fritz.box \
--to=arash@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).