From: Eshel Yaron <me@eshelyaron.com>
To: Arash Esbati <arash@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master de8cae30bcf: Add global minor mode 'global-completion-preview-mode'
Date: Wed, 03 Apr 2024 08:43:21 +0200 [thread overview]
Message-ID: <m1v84zaquu.fsf@sp-byods-145-109-45-144.wireless.uva.nl> (raw)
In-Reply-To: <m2bk6r2yt9.fsf@macmutant.fritz.box> (Arash Esbati's message of "Wed, 03 Apr 2024 00:18:42 +0200")
Hello Arash,
Arash Esbati <arash@gnu.org> writes:
> Eshel Yaron via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
>
[...42 lines elided...]
>> +(define-globalized-minor-mode global-completion-preview-mode
>> + completion-preview-mode completion-preview-mode
>> + :predicate '((not minibuffer-mode special-mode) t))
>> +
>
> Hi Eshel,
>
> in order to do 'M-x global-completion-preview-mode', shouldn't the above
> be autoloaded? In that case, the ";;;###autoload" cookie is missing, I
> think.
You're right, thanks for noticing. It should be fixed in master now.
Cheers,
Eshel
prev parent reply other threads:[~2024-04-03 6:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171187039810.994.12465478999484475234@vcs2.savannah.gnu.org>
[not found] ` <20240331073318.645A2C1FB50@vcs2.savannah.gnu.org>
2024-04-02 22:18 ` master de8cae30bcf: Add global minor mode 'global-completion-preview-mode' Arash Esbati
2024-04-03 6:43 ` Eshel Yaron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1v84zaquu.fsf@sp-byods-145-109-45-144.wireless.uva.nl \
--to=me@eshelyaron.com \
--cc=arash@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).