From: Keith David Bershatsky <esq@lawlist.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: buffer.c/buffer.h: How to add new buffer-local variables?
Date: Sun, 31 Mar 2019 02:03:25 -0700 [thread overview]
Message-ID: <m27ecf76w2.wl%esq@lawlist.com> (raw)
Thank you, Eli, for reading and responding to this particular thread.
I have tried increasing MAX_PER_BUFFER_VARS from 50 to 60 and even 75, but that no longer works. That approach worked back in early/mid-December 2018, but does not work with a current version of Emacs master branch.
I searched pdumper.c for a few popular buffer-local variables such as mode_line_format and cache_long_scans, but did not find them. As such, I have no idea where else to add the new buffer local variables other than the regular locations in buffer.c and buffer.h as demonstrated in the working/broken patches attached to the initial post of this particular thread.
The build messages gives little clues for us to investigate this issue. I have learned how to extract the new hash values from dmpstruct.h and insert them at the appropriate location of pdumper.c, but that is not what causes the build to fail in this particular issue.
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
> Date: [03-30-2019 20:49:57] <31 Mar 2019 06:49:57 +0300>
> From: Eli Zaretskii <eliz@gnu.org>
> To: emacs-devel@gnu.org,Keith David Bershatsky <esq@lawlist.com>
> Subject: Re: buffer.c/buffer.h: How to add new buffer-local variables?
>
> * * *
>
> Could it be you are overflowing MAX_PER_BUFFER_VARS?
next reply other threads:[~2019-03-31 9:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 9:03 Keith David Bershatsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-04-09 3:49 buffer.c/buffer.h: How to add new buffer-local variables? Keith David Bershatsky
2019-04-09 0:48 Keith David Bershatsky
2019-04-09 0:40 Keith David Bershatsky
2019-04-08 8:03 Keith David Bershatsky
2019-04-08 9:37 ` Eli Zaretskii
2019-04-08 15:04 ` Eli Zaretskii
2019-04-08 17:31 ` Andreas Schwab
2019-04-08 17:43 ` Eli Zaretskii
2019-04-08 18:33 ` Stefan Monnier
2019-04-08 20:07 ` Paul Eggert
2019-04-08 22:19 ` Michael Welsh Duggan
2019-04-08 23:06 ` Paul Eggert
2019-04-09 6:13 ` Eli Zaretskii
2019-04-08 4:34 Keith David Bershatsky
2019-04-07 2:50 Keith David Bershatsky
2019-04-07 15:48 ` Eli Zaretskii
2019-04-08 5:23 ` Paul Eggert
2019-04-04 18:57 Keith David Bershatsky
2019-04-04 19:29 ` Eli Zaretskii
2019-04-01 7:43 Keith David Bershatsky
2019-03-31 16:32 Keith David Bershatsky
2019-03-31 20:02 ` Stefan Monnier
2019-03-30 23:19 Keith David Bershatsky
2019-03-31 2:37 ` Eli Zaretskii
2019-03-31 3:49 ` Eli Zaretskii
2019-03-31 9:42 ` Andreas Schwab
2019-03-31 10:06 ` Eli Zaretskii
2019-03-31 11:41 ` Andreas Schwab
2019-03-31 15:10 ` Eli Zaretskii
2019-04-02 16:18 ` Eli Zaretskii
2019-04-02 18:46 ` Daniel Colascione
2019-04-03 17:43 ` Eli Zaretskii
2019-03-31 12:22 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27ecf76w2.wl%esq@lawlist.com \
--to=esq@lawlist.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).