From: Eli Zaretskii <eliz@gnu.org>
To: esq@lawlist.com, eggert@cs.ucla.edu
Cc: emacs-devel@gnu.org
Subject: Re: buffer.c/buffer.h: How to add new buffer-local variables?
Date: Mon, 08 Apr 2019 18:04:28 +0300 [thread overview]
Message-ID: <83a7h08rnn.fsf@gnu.org> (raw)
In-Reply-To: <3C6817C0-1CDB-4F83-805E-BF6B93C77F44@gnu.org> (message from Eli Zaretskii on Mon, 08 Apr 2019 12:37:57 +0300)
> Date: Mon, 08 Apr 2019 12:37:57 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: acm@muc.de, dancol@dancol.org, schwab@linux-m68k.org,
> monnier@iro.umontreal.ca
>
> The problem is caused by the 4-byte hole between the last Lisp_Object member of the buffer structure and the beginning of struct buffer_text. It causes us to decide that a buffer has 83 Lisp components, whereas it actually has only 82. The hole is left uninitialized, and causes the segfault when we try to use it as a valid object.
To clarify, I meant this hole:
> /* 324 | 4 */ Lisp_Object extra_line_spacing_;
> /* 328 | 4 */ Lisp_Object cursor_in_non_selected_windows_;
> /* XXX 4-byte hole */ <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
> /* 336 | 104 */ struct buffer_text {
> /* 336 | 4 */ unsigned char *beg;
Significantly, it doesn't show in what Paul saw in a 32-bit Fedora
build. I guess the MS-Windows port of GCC has some special rules in
this case, perhaps triggered by the fact that some members of 'struct
buffer_text' are now 64-bit integers, and perhaps GCC on Windows wants
them 8-byte aligned?
> I guess we need to make BUFFER_LISP_SIZE smarter?
Not sure how, though. Perhaps we should simply make BUFFER_LISP_SIZE
a literal number and request whoever extends 'struct buffer' to keep
that in sync manually?
next prev parent reply other threads:[~2019-04-08 15:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 8:03 buffer.c/buffer.h: How to add new buffer-local variables? Keith David Bershatsky
2019-04-08 9:37 ` Eli Zaretskii
2019-04-08 15:04 ` Eli Zaretskii [this message]
2019-04-08 17:31 ` Andreas Schwab
2019-04-08 17:43 ` Eli Zaretskii
2019-04-08 18:33 ` Stefan Monnier
2019-04-08 20:07 ` Paul Eggert
2019-04-08 22:19 ` Michael Welsh Duggan
2019-04-08 23:06 ` Paul Eggert
2019-04-09 6:13 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2019-04-09 3:49 Keith David Bershatsky
2019-04-09 0:48 Keith David Bershatsky
2019-04-09 0:40 Keith David Bershatsky
2019-04-08 4:34 Keith David Bershatsky
2019-04-07 2:50 Keith David Bershatsky
2019-04-07 15:48 ` Eli Zaretskii
2019-04-08 5:23 ` Paul Eggert
2019-04-04 18:57 Keith David Bershatsky
2019-04-04 19:29 ` Eli Zaretskii
2019-04-01 7:43 Keith David Bershatsky
2019-03-31 16:32 Keith David Bershatsky
2019-03-31 20:02 ` Stefan Monnier
2019-03-31 9:03 Keith David Bershatsky
2019-03-30 23:19 Keith David Bershatsky
2019-03-31 2:37 ` Eli Zaretskii
2019-03-31 3:49 ` Eli Zaretskii
2019-03-31 9:42 ` Andreas Schwab
2019-03-31 10:06 ` Eli Zaretskii
2019-03-31 11:41 ` Andreas Schwab
2019-03-31 15:10 ` Eli Zaretskii
2019-04-02 16:18 ` Eli Zaretskii
2019-04-02 18:46 ` Daniel Colascione
2019-04-03 17:43 ` Eli Zaretskii
2019-03-31 12:22 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a7h08rnn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=esq@lawlist.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).