From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: mwd@md5i.com, emacs-devel@gnu.org
Subject: Re: buffer.c/buffer.h: How to add new buffer-local variables?
Date: Tue, 09 Apr 2019 09:13:59 +0300 [thread overview]
Message-ID: <83tvf77ljs.fsf@gnu.org> (raw)
In-Reply-To: <16aa8fe9-82dc-c3f6-dbb5-1027ef8ae796@cs.ucla.edu> (message from Paul Eggert on Mon, 8 Apr 2019 16:06:07 -0700)
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Mon, 8 Apr 2019 16:06:07 -0700
>
> On 4/8/19 3:19 PM, Michael Welsh Duggan wrote:
> > I would also add a comment after the
> > cursor_in_non_selected_windows_ entry to the effect that the define
> > needs to be updated if more are added afterward.
>
> There's already a comment there to that effect, and similar comments
> near similar boundaries in other structures. A patch to regularize
> and/or clarify them would be welcome.
>
> Not sure I want to add a macro, though, as it's one more thing to
> maintain and it's not clear it's worth the hassle since one can get the
> macro wrong too.
I agree. A macro doesn't necessarily tell what it's replaced with, so
when you read code which uses the macro, you many times need to look
up that macro to understand what it hides. A comment doesn't have
this problem.
next prev parent reply other threads:[~2019-04-09 6:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 8:03 buffer.c/buffer.h: How to add new buffer-local variables? Keith David Bershatsky
2019-04-08 9:37 ` Eli Zaretskii
2019-04-08 15:04 ` Eli Zaretskii
2019-04-08 17:31 ` Andreas Schwab
2019-04-08 17:43 ` Eli Zaretskii
2019-04-08 18:33 ` Stefan Monnier
2019-04-08 20:07 ` Paul Eggert
2019-04-08 22:19 ` Michael Welsh Duggan
2019-04-08 23:06 ` Paul Eggert
2019-04-09 6:13 ` Eli Zaretskii [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-04-09 3:49 Keith David Bershatsky
2019-04-09 0:48 Keith David Bershatsky
2019-04-09 0:40 Keith David Bershatsky
2019-04-08 4:34 Keith David Bershatsky
2019-04-07 2:50 Keith David Bershatsky
2019-04-07 15:48 ` Eli Zaretskii
2019-04-08 5:23 ` Paul Eggert
2019-04-04 18:57 Keith David Bershatsky
2019-04-04 19:29 ` Eli Zaretskii
2019-04-01 7:43 Keith David Bershatsky
2019-03-31 16:32 Keith David Bershatsky
2019-03-31 20:02 ` Stefan Monnier
2019-03-31 9:03 Keith David Bershatsky
2019-03-30 23:19 Keith David Bershatsky
2019-03-31 2:37 ` Eli Zaretskii
2019-03-31 3:49 ` Eli Zaretskii
2019-03-31 9:42 ` Andreas Schwab
2019-03-31 10:06 ` Eli Zaretskii
2019-03-31 11:41 ` Andreas Schwab
2019-03-31 15:10 ` Eli Zaretskii
2019-04-02 16:18 ` Eli Zaretskii
2019-04-02 18:46 ` Daniel Colascione
2019-04-03 17:43 ` Eli Zaretskii
2019-03-31 12:22 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tvf77ljs.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=mwd@md5i.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).