From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Keith David Bershatsky Newsgroups: gmane.emacs.devel Subject: Re: buffer.c/buffer.h: How to add new buffer-local variables? Date: Sun, 31 Mar 2019 02:03:25 -0700 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="6496"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 31 11:03:54 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hAWNd-0001Yf-N0 for ged-emacs-devel@m.gmane.org; Sun, 31 Mar 2019 11:03:54 +0200 Original-Received: from localhost ([127.0.0.1]:44820 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAWNc-0005cu-Kv for ged-emacs-devel@m.gmane.org; Sun, 31 Mar 2019 05:03:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAWNW-0005cc-2e for emacs-devel@gnu.org; Sun, 31 Mar 2019 05:03:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hAWNT-0001gu-Uo for emacs-devel@gnu.org; Sun, 31 Mar 2019 05:03:44 -0400 Original-Received: from gateway33.websitewelcome.com ([192.185.146.195]:37010) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hAWNQ-0001Z2-I7 for emacs-devel@gnu.org; Sun, 31 Mar 2019 05:03:41 -0400 Original-Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 5EF9E132EB for ; Sun, 31 Mar 2019 04:03:27 -0500 (CDT) Original-Received: from gator3053.hostgator.com ([50.87.144.69]) by cmsmtp with SMTP id AWNChIq70iQerAWNDh4SU9; Sun, 31 Mar 2019 04:03:27 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lawlist.com ; s=default; h=Content-Type:MIME-Version:Subject:Cc:To:From:Message-ID:Date: Sender:Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XLxC2gFOd2+Wv+wd5tcgOnSI3j8mzRDwnkfCGBosk8Q=; b=gpQRkXome2EWhlstwnaPxXiR8F JeMywoVmbPJ336wmqPZkM9Nx3shM05Cb1ohcbQo7ot14q/omaw7KNwG3/xoz8Ocyoliyz0paVucKp UTTG+Bzqt9cAN+NMowmcbDFVi501YHSiycFEG4uAkvqTlCJnA7D3Q3Zkn1h3PIsN1166Zvth9ZwIA bgmu43ViLm6NGxCh85sg7vfa+y3ibLVTqLQ4P6uoU1wHfRWtf3Kr2DugIjISuG1DOwGMrYDeb64kY 04/IdeVz03RFCBYaNoM9t6bDV6NgEa0qf1MvLYjK4UanbV+f+Le+AR+XvU+A2bKYIRWbpneDDuLv5 GlI2LTwA==; Original-Received: from cpe-45-48-239-195.socal.res.rr.com ([45.48.239.195]:49286 helo=server.local) by gator3053.hostgator.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.91) (envelope-from ) id 1hAWNC-002USL-IJ; Sun, 31 Mar 2019 04:03:26 -0500 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator3053.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lawlist.com X-BWhitelist: no X-Source-IP: 45.48.239.195 X-Source-L: No X-Exim-ID: 1hAWNC-002USL-IJ X-Source-Sender: cpe-45-48-239-195.socal.res.rr.com (server.local) [45.48.239.195]:49286 X-Source-Auth: lawlist X-Email-Count: 1 X-Source-Cap: bGF3bGlzdDtsYXdsaXN0O2dhdG9yMzA1My5ob3N0Z2F0b3IuY29t X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 192.185.146.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234834 Archived-At: Thank you, Eli, for reading and responding to this particular thread. I have tried increasing MAX_PER_BUFFER_VARS from 50 to 60 and even 75, but that no longer works. That approach worked back in early/mid-December 2018, but does not work with a current version of Emacs master branch. I searched pdumper.c for a few popular buffer-local variables such as mode_line_format and cache_long_scans, but did not find them. As such, I have no idea where else to add the new buffer local variables other than the regular locations in buffer.c and buffer.h as demonstrated in the working/broken patches attached to the initial post of this particular thread. The build messages gives little clues for us to investigate this issue. I have learned how to extract the new hash values from dmpstruct.h and insert them at the appropriate location of pdumper.c, but that is not what causes the build to fail in this particular issue. ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > Date: [03-30-2019 20:49:57] <31 Mar 2019 06:49:57 +0300> > From: Eli Zaretskii > To: emacs-devel@gnu.org,Keith David Bershatsky > Subject: Re: buffer.c/buffer.h: How to add new buffer-local variables? > > * * * > > Could it be you are overflowing MAX_PER_BUFFER_VARS?