* Re: [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join
[not found] ` <E1YcAWy-0005kD-MO@vcs.savannah.gnu.org>
@ 2015-03-30 1:12 ` Stefan Monnier
2015-03-30 6:59 ` Artur Malabarba
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Monnier @ 2015-03-30 1:12 UTC (permalink / raw)
To: emacs-devel; +Cc: Artur Malabarba
> Move package-version-join to subr.el as version-join
Why do you need it in subr.el?
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join
2015-03-30 1:12 ` [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join Stefan Monnier
@ 2015-03-30 6:59 ` Artur Malabarba
2015-03-30 14:02 ` Stefan Monnier
0 siblings, 1 reply; 8+ messages in thread
From: Artur Malabarba @ 2015-03-30 6:59 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
I don't, and I can move it back if preferred. I just put it together with
the other version-* functions.
On Mar 30, 2015 2:12 AM, "Stefan Monnier" <monnier@iro.umontreal.ca> wrote:
>
> > Move package-version-join to subr.el as version-join
>
> Why do you need it in subr.el?
>
>
> Stefan
[-- Attachment #2: Type: text/html, Size: 461 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join
2015-03-30 6:59 ` Artur Malabarba
@ 2015-03-30 14:02 ` Stefan Monnier
2015-03-30 16:11 ` Artur Malabarba
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Monnier @ 2015-03-30 14:02 UTC (permalink / raw)
To: Artur Malabarba; +Cc: emacs-devel
> I don't, and I can move it back if preferred. I just put it together with
> the other version-* functions.
The others are in subr.el because the hordes were clamoring for ways to
test versions numbers instead of testing feature presence.
I understand that placing version-join next to it would be logical, but
if it's only used by package.el, then I think it can just as well stay
there.
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join
2015-03-30 14:02 ` Stefan Monnier
@ 2015-03-30 16:11 ` Artur Malabarba
2015-03-30 21:03 ` Stefan Monnier
0 siblings, 1 reply; 8+ messages in thread
From: Artur Malabarba @ 2015-03-30 16:11 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Sure, no problem.
Since nobody replied negatively to the other thread, is it ok if I
clean up the commits and merge to master? (keeping `version-join' in
package.el).
2015-03-30 15:02 GMT+01:00 Stefan Monnier <monnier@iro.umontreal.ca>:
>> I don't, and I can move it back if preferred. I just put it together with
>> the other version-* functions.
>
> The others are in subr.el because the hordes were clamoring for ways to
> test versions numbers instead of testing feature presence.
>
> I understand that placing version-join next to it would be logical, but
> if it's only used by package.el, then I think it can just as well stay
> there.
>
>
> Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join
2015-03-30 16:11 ` Artur Malabarba
@ 2015-03-30 21:03 ` Stefan Monnier
2015-03-30 22:11 ` Artur Malabarba
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Monnier @ 2015-03-30 21:03 UTC (permalink / raw)
To: Artur Malabarba; +Cc: emacs-devel
> Since nobody replied negatively to the other thread, is it ok if I
> clean up the commits and merge to master? (keeping `version-join' in
> package.el).
I don't object: I generally don't like such moving around since it makes
subsequent history-digging harder, but if it increases your motivation
enough to go and improve the package, I guess it's a good tradeoff.
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join
2015-03-30 21:03 ` Stefan Monnier
@ 2015-03-30 22:11 ` Artur Malabarba
0 siblings, 0 replies; 8+ messages in thread
From: Artur Malabarba @ 2015-03-30 22:11 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
2015-03-30 22:03 GMT+01:00 Stefan Monnier <monnier@iro.umontreal.ca>:
>> Since nobody replied negatively to the other thread, is it ok if I
>> clean up the commits and merge to master? (keeping `version-join' in
>> package.el).
>
> I don't object: I generally don't like such moving around since it makes
> subsequent history-digging harder, but if it increases your motivation
> enough to go and improve the package, I guess it's a good tradeoff.
It has motivated me enough to implement async refreshing. :-)
^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <E1YcAWz-0005kV-O6@vcs.savannah.gnu.org>]
end of thread, other threads:[~2015-03-30 22:11 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20150329103323.22001.15986@vcs.savannah.gnu.org>
[not found] ` <E1YcAWy-0005kD-MO@vcs.savannah.gnu.org>
2015-03-30 1:12 ` [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join Stefan Monnier
2015-03-30 6:59 ` Artur Malabarba
2015-03-30 14:02 ` Stefan Monnier
2015-03-30 16:11 ` Artur Malabarba
2015-03-30 21:03 ` Stefan Monnier
2015-03-30 22:11 ` Artur Malabarba
[not found] ` <E1YcAWz-0005kV-O6@vcs.savannah.gnu.org>
2015-03-30 1:26 ` [Emacs-diffs] scratch/organizing-package.el 830cd2a 3/5: Reorganize package.el and divide it with page-breaks and comments Stefan Monnier
2015-03-30 7:23 ` Artur Malabarba
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).