From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join Date: Mon, 30 Mar 2015 17:11:40 +0100 Message-ID: References: <20150329103323.22001.15986@vcs.savannah.gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1427731940 5199 80.91.229.3 (30 Mar 2015 16:12:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 30 Mar 2015 16:12:20 +0000 (UTC) Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 30 18:12:15 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YccIE-0005eZ-O6 for ged-emacs-devel@m.gmane.org; Mon, 30 Mar 2015 18:12:02 +0200 Original-Received: from localhost ([::1]:34927 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YccIE-0000pb-2y for ged-emacs-devel@m.gmane.org; Mon, 30 Mar 2015 12:12:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YccHu-0000n4-9W for emacs-devel@gnu.org; Mon, 30 Mar 2015 12:11:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YccHt-0000v4-EZ for emacs-devel@gnu.org; Mon, 30 Mar 2015 12:11:42 -0400 Original-Received: from mail-lb0-x22c.google.com ([2a00:1450:4010:c04::22c]:35103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YccHt-0000ur-7U for emacs-devel@gnu.org; Mon, 30 Mar 2015 12:11:41 -0400 Original-Received: by lbdc10 with SMTP id c10so44500820lbd.2 for ; Mon, 30 Mar 2015 09:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=Y2YqTqxavDQlwWF4xh2njdSlRprUfHQuZIuuuw9LeoE=; b=Yka61uipNoIDG9Zp0HuUwc4+rpYoujc4Prk43cYf0cM7gMaMCzI09hK/tPpTqfNKEH t63LT4i81/+uhrOU4ekgDZOItU/j8zjTZTH0RJQx75R1UaSrzIi6bhMZFl0RRhL4zv7M u6J2I+5/gyZZXZl+fdMEW6dPCbiSawytX/MgGm3HdYIT4togdbug9Mta9UtZoe9hMABQ a7uIMgAX0OMiTlfknVzbaDb4ltXlQHHjtKS9paq3LcNXAReFY9I0zL8mF35Bf8NixMpV 4ppvI+l+/e2UmnBsKD3SgiKxcO2b2HDWc1T40Eyg0Kf6IK8JHOMhSVzk8a4j/b+RQEjo wZIA== X-Received: by 10.152.9.195 with SMTP id c3mr25509043lab.80.1427731900367; Mon, 30 Mar 2015 09:11:40 -0700 (PDT) Original-Received: by 10.112.207.225 with HTTP; Mon, 30 Mar 2015 09:11:40 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: 8FclkFeKexyTCBGCeWrFYZVu9Qk X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:184554 Archived-At: Sure, no problem. Since nobody replied negatively to the other thread, is it ok if I clean up the commits and merge to master? (keeping `version-join' in package.el). 2015-03-30 15:02 GMT+01:00 Stefan Monnier : >> I don't, and I can move it back if preferred. I just put it together with >> the other version-* functions. > > The others are in subr.el because the hordes were clamoring for ways to > test versions numbers instead of testing feature presence. > > I understand that placing version-join next to it would be logical, but > if it's only used by package.el, then I think it can just as well stay > there. > > > Stefan