From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join
Date: Mon, 30 Mar 2015 17:11:40 +0100 [thread overview]
Message-ID: <CAAdUY-+FGGEmJ9j5tLpaPk=5m-CMQtot9g7W2G9+rH-xTNws8Q@mail.gmail.com> (raw)
In-Reply-To: <jwvsicmegax.fsf-monnier+emacsdiffs@gnu.org>
Sure, no problem.
Since nobody replied negatively to the other thread, is it ok if I
clean up the commits and merge to master? (keeping `version-join' in
package.el).
2015-03-30 15:02 GMT+01:00 Stefan Monnier <monnier@iro.umontreal.ca>:
>> I don't, and I can move it back if preferred. I just put it together with
>> the other version-* functions.
>
> The others are in subr.el because the hordes were clamoring for ways to
> test versions numbers instead of testing feature presence.
>
> I understand that placing version-join next to it would be logical, but
> if it's only used by package.el, then I think it can just as well stay
> there.
>
>
> Stefan
next prev parent reply other threads:[~2015-03-30 16:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150329103323.22001.15986@vcs.savannah.gnu.org>
[not found] ` <E1YcAWy-0005kD-MO@vcs.savannah.gnu.org>
2015-03-30 1:12 ` [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join Stefan Monnier
2015-03-30 6:59 ` Artur Malabarba
2015-03-30 14:02 ` Stefan Monnier
2015-03-30 16:11 ` Artur Malabarba [this message]
2015-03-30 21:03 ` Stefan Monnier
2015-03-30 22:11 ` Artur Malabarba
[not found] ` <E1YcAWz-0005kV-O6@vcs.savannah.gnu.org>
2015-03-30 1:26 ` [Emacs-diffs] scratch/organizing-package.el 830cd2a 3/5: Reorganize package.el and divide it with page-breaks and comments Stefan Monnier
2015-03-30 7:23 ` Artur Malabarba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAdUY-+FGGEmJ9j5tLpaPk=5m-CMQtot9g7W2G9+rH-xTNws8Q@mail.gmail.com' \
--to=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).