Re: master b2e2128: Use lexical-binding in webjump.el and add tests

Re: master b2e2128: Use lexical-binding in webjump.el and add tests

[Lars Ingebrigtsen]

Simen Heggestøyl <simenheg@gmail.com> writes:

>     * lisp/net/webjump.el: Use lexical-binding.
>     (webjump-read-url-choice): Remove redundant 'function' around lambda.

This seems like a good thing, but it made me curious as to how many
(function (lambda ...)) things there are in Emacs.  Just naive grepping
showed me ~300 of them; I'm guessing there's even more.

Most look like they can definitely be removed:

	  (setq split-by-major-mode
		(sort split-by-major-mode
		      (function (lambda (elt1 elt2)
				  (> (length elt1) (length elt2))))))

But there's a lot of these things:

(put 'pascal 'math-radix-formatter
     (function (lambda (r s)
		 (if (= r 16) (format "$%s" s)
		   (format "%d#%s" r s)))))

Does the `function' here have any meaning, or is it superfluous?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master b2e2128: Use lexical-binding in webjump.el and add tests

[Noam Postavsky]

On Mon, 18 May 2020 at 15:40, Lars Ingebrigtsen <larsi@gnus.org> wrote:

>      (function (lambda (r s)

> Does the `function' here have any meaning, or is it superfluous?

It has meaning, and it's superfluous because the lambda macro expands
into a function form if you omit it.

Re: master b2e2128: Use lexical-binding in webjump.el and add tests

[Stefan Monnier]

> 	  (setq split-by-major-mode
> 		(sort split-by-major-mode
> 		      (function (lambda (elt1 elt2)
> 				  (> (length elt1) (length elt2))))))
>
> But there's a lot of these things:
>
> (put 'pascal 'math-radix-formatter
>      (function (lambda (r s)
> 		 (if (= r 16) (format "$%s" s)
> 		   (format "%d#%s" r s)))))
>
> Does the `function' here have any meaning, or is it superfluous?

It has the same meaning in both cases: in both cases (function (lambda ...))
is an argument to a function (`sort` in the first case and `put` in the
second).


        Stefan

Re: master b2e2128: Use lexical-binding in webjump.el and add tests

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> (put 'pascal 'math-radix-formatter
>>      (function (lambda (r s)
>> 		 (if (= r 16) (format "$%s" s)
>> 		   (format "%d#%s" r s)))))
>>
>> Does the `function' here have any meaning, or is it superfluous?
>
> It has the same meaning in both cases: in both cases (function (lambda ...))
> is an argument to a function (`sort` in the first case and `put` in the
> second).

The English language changes so quickly these days!  That's an entirely
new way of spelling "`function' here has no meaning, and it's
superfluous", I guess.

Anyway, I guess that means that somebody who wants do some cleaning up
has a new thing to grep for.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no