From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master b2e2128: Use lexical-binding in webjump.el and add tests Date: Mon, 18 May 2020 21:40:21 +0200 Message-ID: <878shpt4ka.fsf@gnus.org> References: <20200518155819.860.31976@vcs0.savannah.gnu.org> <20200518155821.3673B20A2C@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="108936"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 18 21:41:16 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jaldU-000SEs-5N for ged-emacs-devel@m.gmane-mx.org; Mon, 18 May 2020 21:41:16 +0200 Original-Received: from localhost ([::1]:58394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaldT-0001hR-8K for ged-emacs-devel@m.gmane-mx.org; Mon, 18 May 2020 15:41:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jalcp-0001DQ-2n for emacs-devel@gnu.org; Mon, 18 May 2020 15:40:35 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:34436) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jalcn-0004Ba-Nz for emacs-devel@gnu.org; Mon, 18 May 2020 15:40:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:To:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bS6COVY/U9gtP1/fOGvtD4pYDNc86bpEbE3KvlZ2E/M=; b=i0QZ+fhOpreEq/3pNyhXqbZxuI EtwNYa7rRsZhKNtupwAuRA6EhCLQClmE+ivGUmdrr9ZAP6zVUchtX/0KuT6G80EgfxEnT9Q6HXJZv 04cC/Ait2nIrcTxuGqsWs3fGoNzd9BrQPIuKCbFT76WAUTq1DT6Tu2bH8Az6eXy1oAEk=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jalcc-0007DQ-Pr for emacs-devel@gnu.org; Mon, 18 May 2020 21:40:27 +0200 In-Reply-To: <20200518155821.3673B20A2C@vcs0.savannah.gnu.org> ("Simen =?utf-8?Q?Heggest=C3=B8yl=22's?= message of "Mon, 18 May 2020 11:58:20 -0400 (EDT)") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250816 Archived-At: Simen Heggest=C3=B8yl writes: > * lisp/net/webjump.el: Use lexical-binding. > (webjump-read-url-choice): Remove redundant 'function' around lambda. This seems like a good thing, but it made me curious as to how many (function (lambda ...)) things there are in Emacs. Just naive grepping showed me ~300 of them; I'm guessing there's even more. Most look like they can definitely be removed: (setq split-by-major-mode (sort split-by-major-mode (function (lambda (elt1 elt2) (> (length elt1) (length elt2)))))) But there's a lot of these things: (put 'pascal 'math-radix-formatter (function (lambda (r s) (if (=3D r 16) (format "$%s" s) (format "%d#%s" r s))))) Does the `function' here have any meaning, or is it superfluous? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no