unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: emacs-devel@gnu.org
Subject: Re: master b2e2128: Use lexical-binding in webjump.el and add tests
Date: Mon, 18 May 2020 21:40:21 +0200	[thread overview]
Message-ID: <878shpt4ka.fsf@gnus.org> (raw)
In-Reply-To: <20200518155821.3673B20A2C@vcs0.savannah.gnu.org> ("Simen Heggestøyl"'s message of "Mon, 18 May 2020 11:58:20 -0400 (EDT)")

Simen Heggestøyl <simenheg@gmail.com> writes:

>     * lisp/net/webjump.el: Use lexical-binding.
>     (webjump-read-url-choice): Remove redundant 'function' around lambda.

This seems like a good thing, but it made me curious as to how many
(function (lambda ...)) things there are in Emacs.  Just naive grepping
showed me ~300 of them; I'm guessing there's even more.

Most look like they can definitely be removed:

	  (setq split-by-major-mode
		(sort split-by-major-mode
		      (function (lambda (elt1 elt2)
				  (> (length elt1) (length elt2))))))

But there's a lot of these things:

(put 'pascal 'math-radix-formatter
     (function (lambda (r s)
		 (if (= r 16) (format "$%s" s)
		   (format "%d#%s" r s)))))

Does the `function' here have any meaning, or is it superfluous?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



       reply	other threads:[~2020-05-18 19:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200518155819.860.31976@vcs0.savannah.gnu.org>
     [not found] ` <20200518155821.3673B20A2C@vcs0.savannah.gnu.org>
2020-05-18 19:40   ` Lars Ingebrigtsen [this message]
2020-05-18 20:23     ` master b2e2128: Use lexical-binding in webjump.el and add tests Noam Postavsky
2020-05-18 21:18     ` Stefan Monnier
2020-05-19 12:40       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878shpt4ka.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).