unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Artur Malabarba <bruce.connor.am@gmail.com>
Cc: Yuri D'Elia <wavexx@thregr.org>, emacs-devel@gnu.org
Subject: Re: Allowing symlinked dir-locals files?
Date: Mon, 16 Aug 2021 14:10:33 -0400	[thread overview]
Message-ID: <jwvtujpxnyj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8735r91d73.fsf@wavexx.thregr.org> (Yuri D'Elia's message of "Mon, 16 Aug 2021 20:01:20 +0200")

Hi Artur,

Yuri D'Elia [2021-08-16 20:01:20] wrote:
> I was trying to share some localized customization by symlinking a
> .dir-locals.el file across directories, but it doesn't seem to work.
>
> Looking at the current files.el:4330, we explicitly check if the file is
> a regular file. And looking at the FIXME comment just above I concur

AFAICT, this `file-regular-p` check (used in addition
to `(not (file-directory-p f))`) was introduced by your:

    commit f0b82b34536e6bafbecbd642eee0cb0f534f8647
    Author: Artur Malabarba <bruce.connor.am@gmail.com>
    Date:   Sat Jan 16 08:50:46 2016 +0000
    
        * lisp/files.el (dir-locals--all-files): Use completion instead of wildcards
        
        (dir-locals-file)
        * lisp/files-x.el (modify-dir-local-variable)
        * lisp/dos-fns.el (dosified-file-name)
        * lisp/help-fns.el (describe-variable): Change accordingly.

Do you remember why added it?


        Stefan




  reply	other threads:[~2021-08-16 18:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16 18:01 Allowing symlinked dir-locals files? Yuri D'Elia
2021-08-16 18:10 ` Stefan Monnier [this message]
2021-08-16 18:12 ` Eli Zaretskii
2021-08-16 18:25   ` Yuri D'Elia
2021-08-16 18:39   ` Andreas Schwab
2021-09-18 14:10     ` Yuri D'Elia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtujpxnyj.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=wavexx@thregr.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).