From: Yuri D'Elia <wavexx@thregr.org>
To: emacs-devel@gnu.org
Subject: Re: Allowing symlinked dir-locals files?
Date: Sat, 18 Sep 2021 16:10:47 +0200 [thread overview]
Message-ID: <87pmt6dleg.fsf@wavexx.thregr.org> (raw)
In-Reply-To: 874kbpkzdy.fsf@igel.home
On Mon, Aug 16 2021, Andreas Schwab wrote:
>>> Looking at the current files.el:4330, we explicitly check if the file is
>>> a regular file.
>
> Why is that a problem? If the symlink points to a regular file, it is
> still a file-regular-p.
>
>> Yes. It could also be a symlink injected by malevolent hackers.
>
> Is that different from a regular file injected by malevolent hackers?
I was giving more thought to this. I don't think there's any difference.
Assuming we're reading a versioned .dir-locals.el file, there's no way
to distinguish between a benevolent (local) file and the versioned file.
We still need to obey safe-local-variable-values just like any other
file, and AFAIK we have no concept of "trusted paths" for dir-locals
where resolution could be ambiguous.
prev parent reply other threads:[~2021-09-18 14:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 18:01 Allowing symlinked dir-locals files? Yuri D'Elia
2021-08-16 18:10 ` Stefan Monnier
2021-08-16 18:12 ` Eli Zaretskii
2021-08-16 18:25 ` Yuri D'Elia
2021-08-16 18:39 ` Andreas Schwab
2021-09-18 14:10 ` Yuri D'Elia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmt6dleg.fsf@wavexx.thregr.org \
--to=wavexx@thregr.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).