From: Eli Zaretskii <eliz@gnu.org>
To: Yuri D'Elia <wavexx@thregr.org>
Cc: emacs-devel@gnu.org
Subject: Re: Allowing symlinked dir-locals files?
Date: Mon, 16 Aug 2021 21:12:16 +0300 [thread overview]
Message-ID: <83o89x6yyn.fsf@gnu.org> (raw)
In-Reply-To: <8735r91d73.fsf@wavexx.thregr.org> (message from Yuri D'Elia on Mon, 16 Aug 2021 20:01:20 +0200)
> From: Yuri D'Elia <wavexx@thregr.org>
> Date: Mon, 16 Aug 2021 20:01:20 +0200
>
> Looking at the current files.el:4330, we explicitly check if the file is
> a regular file. And looking at the FIXME comment just above I concur
> that checking just for file-directory-p should be sufficient for proper
> behavior.
>
> However I suspect that the rationale was to be proper as well as "safe",
> as this could be used to make emacs read/interpret another file if the
> symlink is under the control of a VCS or via a shared-filesystem.
Yes. It could also be a symlink injected by malevolent hackers.
next prev parent reply other threads:[~2021-08-16 18:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 18:01 Allowing symlinked dir-locals files? Yuri D'Elia
2021-08-16 18:10 ` Stefan Monnier
2021-08-16 18:12 ` Eli Zaretskii [this message]
2021-08-16 18:25 ` Yuri D'Elia
2021-08-16 18:39 ` Andreas Schwab
2021-09-18 14:10 ` Yuri D'Elia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o89x6yyn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=wavexx@thregr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).