From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Allowing symlinked dir-locals files? Date: Mon, 16 Aug 2021 14:10:33 -0400 Message-ID: References: <8735r91d73.fsf@wavexx.thregr.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9899"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Yuri D'Elia , emacs-devel@gnu.org To: Artur Malabarba Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 16 20:13:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFh76-0002Qs-J2 for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Aug 2021 20:13:32 +0200 Original-Received: from localhost ([::1]:41150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFh75-0006Rw-Kf for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Aug 2021 14:13:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFh4M-0003Rz-Cu for emacs-devel@gnu.org; Mon, 16 Aug 2021 14:10:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17227) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFh4H-00015m-Pf for emacs-devel@gnu.org; Mon, 16 Aug 2021 14:10:39 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D889A80925; Mon, 16 Aug 2021 14:10:35 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7B6FD8064E; Mon, 16 Aug 2021 14:10:34 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1629137434; bh=JTfTRSEMpGoaZtEtX3AntHM6uka6svzoVfrwdAAt6aA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=bypq54ixzdeI2c1p7ilGLy5/pSwX4pM+b6JS551UOS8SxpUeP3AE7Tkpe1jiMbZxC UMrL4FK6JD2yVbNHHispQ0xryxqNqPpB0qQQil3mH85EXBK7LkXg0zghSK+xiH/QqR uRY0GgOeF7c0RuUftgBEQXQDf7dvkGSURWYvXa1ac1ldK/dN7BxVCb3YWQMpWOu9fy VN/Nef1cWjQXL2N6R41YaEvElHSDz27pyxHNSKlRIDLxGlIh+6PvdzsaZRtCvWvFvq AEXFQdOavJAemXsl1k12vmv5OvzZYAiRTCJXcOmXlviIIHqJjr6ve4tTr3Hisu1R3F meg7/+Iy+2k0Q== Original-Received: from alfajor (unknown [104.247.244.135]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 45C15120340; Mon, 16 Aug 2021 14:10:34 -0400 (EDT) In-Reply-To: <8735r91d73.fsf@wavexx.thregr.org> (Yuri D'Elia's message of "Mon, 16 Aug 2021 20:01:20 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272455 Archived-At: Hi Artur, Yuri D'Elia [2021-08-16 20:01:20] wrote: > I was trying to share some localized customization by symlinking a > .dir-locals.el file across directories, but it doesn't seem to work. > > Looking at the current files.el:4330, we explicitly check if the file is > a regular file. And looking at the FIXME comment just above I concur AFAICT, this `file-regular-p` check (used in addition to `(not (file-directory-p f))`) was introduced by your: commit f0b82b34536e6bafbecbd642eee0cb0f534f8647 Author: Artur Malabarba Date: Sat Jan 16 08:50:46 2016 +0000 * lisp/files.el (dir-locals--all-files): Use completion instead of wildcards (dir-locals-file) * lisp/files-x.el (modify-dir-local-variable) * lisp/dos-fns.el (dosified-file-name) * lisp/help-fns.el (describe-variable): Change accordingly. Do you remember why added it? Stefan