unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [elpa] externals/posframe acf0fbe 1/2: * posframe.el: Silence byte-compiler.
       [not found] ` <20210530235711.A8932209BF@vcs0.savannah.gnu.org>
@ 2021-05-31  0:15   ` Stefan Monnier
  0 siblings, 0 replies; only message in thread
From: Stefan Monnier @ 2021-05-31  0:15 UTC (permalink / raw)
  To: Jonas Bernoulli; +Cc: emacs-devel

>  (if (version< emacs-version "27.1")
> -    (add-hook 'focus-in-hook #'posframe--redirect-posframe-focus)
> +    (with-no-warnings
> +      (add-hook 'focus-in-hook #'posframe--redirect-posframe-focus))
>    (add-function :after after-focus-change-function #'posframe--redirect-posframe-focus))

I know it's not the part of the code you changed, but (version< emacs-version "27.1")
should probably be replaced with the simpler (< emacs-major-version 27),
tho (boundp 'after-focus-change-function) would be fine as well ;-).


        Stefan




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-05-31  0:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210530235710.9973.73256@vcs0.savannah.gnu.org>
     [not found] ` <20210530235711.A8932209BF@vcs0.savannah.gnu.org>
2021-05-31  0:15   ` [elpa] externals/posframe acf0fbe 1/2: * posframe.el: Silence byte-compiler Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).