From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/posframe acf0fbe 1/2: * posframe.el: Silence byte-compiler. Date: Sun, 30 May 2021 20:15:59 -0400 Message-ID: References: <20210530235710.9973.73256@vcs0.savannah.gnu.org> <20210530235711.A8932209BF@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27799"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Jonas Bernoulli Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 31 02:17:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnVce-00072a-1K for ged-emacs-devel@m.gmane-mx.org; Mon, 31 May 2021 02:17:36 +0200 Original-Received: from localhost ([::1]:54874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnVcd-0005tu-1m for ged-emacs-devel@m.gmane-mx.org; Sun, 30 May 2021 20:17:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnVbK-0005Ae-P1 for emacs-devel@gnu.org; Sun, 30 May 2021 20:16:14 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16727) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnVbD-0005YE-MG for emacs-devel@gnu.org; Sun, 30 May 2021 20:16:13 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 33B12440F92; Sun, 30 May 2021 20:16:06 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BDF81440F2E; Sun, 30 May 2021 20:16:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1622420160; bh=gXMiSMytwUDd4DD2T5qrk1AWZkFXykKCS7aCkdsYJeI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=JxFu97tp5eXUh6U3jyhff/F3/Uv44FEWx4HcxEBd8M/dYJQcMNsY0Qq2CaUXKUJR1 o1OsM1VMv3PL2l0hZzXEzmHrTCWoi5gEj5ThPZe99WoA/5DV0pbeKPqqhyy8ts9UC3 1Bt7Dz6UJKJtHj9LTpn3uo6jqwfSwvAxt7a861aP8fQ1vPX70zGgyMXvAGv3ZVAdXX 1LgMovJDbCFiXWTqDqb0w69242sFlds1DIMolGyf9jf4E/2LUeNV4nOgqLyfhdih/9 8wDpuzsfazJmq5fzhPXd80XZhSGvMhEVJQNmiWRrPFXt12RiuDCryPPhWhmsVP5X+Y AcYqN9ArFO/4w== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 89F1D120E31; Sun, 30 May 2021 20:16:00 -0400 (EDT) In-Reply-To: <20210530235711.A8932209BF@vcs0.savannah.gnu.org> (ELPA Syncer's message of "Sun, 30 May 2021 19:57:11 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270151 Archived-At: > (if (version< emacs-version "27.1") > - (add-hook 'focus-in-hook #'posframe--redirect-posframe-focus) > + (with-no-warnings > + (add-hook 'focus-in-hook #'posframe--redirect-posframe-focus)) > (add-function :after after-focus-change-function #'posframe--redirect-posframe-focus)) I know it's not the part of the code you changed, but (version< emacs-version "27.1") should probably be replaced with the simpler (< emacs-major-version 27), tho (boundp 'after-focus-change-function) would be fine as well ;-). Stefan