From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Jonas Bernoulli <jonas@bernoul.li>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] externals/posframe acf0fbe 1/2: * posframe.el: Silence byte-compiler.
Date: Sun, 30 May 2021 20:15:59 -0400 [thread overview]
Message-ID: <jwvr1hnvjz5.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20210530235711.A8932209BF@vcs0.savannah.gnu.org> (ELPA Syncer's message of "Sun, 30 May 2021 19:57:11 -0400 (EDT)")
> (if (version< emacs-version "27.1")
> - (add-hook 'focus-in-hook #'posframe--redirect-posframe-focus)
> + (with-no-warnings
> + (add-hook 'focus-in-hook #'posframe--redirect-posframe-focus))
> (add-function :after after-focus-change-function #'posframe--redirect-posframe-focus))
I know it's not the part of the code you changed, but (version< emacs-version "27.1")
should probably be replaced with the simpler (< emacs-major-version 27),
tho (boundp 'after-focus-change-function) would be fine as well ;-).
Stefan
parent reply other threads:[~2021-05-31 0:15 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210530235711.A8932209BF@vcs0.savannah.gnu.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr1hnvjz5.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=jonas@bernoul.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).