* Re: [elpa] externals/hcel 9dc18bef43 11/13: fixing header comments [not found] ` <20220921125749.050E0C12D95@vcs2.savannah.gnu.org> @ 2022-09-21 13:21 ` Stefan Monnier 2022-09-29 4:47 ` Yuchen Pei 0 siblings, 1 reply; 2+ messages in thread From: Stefan Monnier @ 2022-09-21 13:21 UTC (permalink / raw) To: emacs-devel; +Cc: Yuchen Pei > - (get-text-property (1- (point)) prop))) > + (get-text-property (max 0 (1- (point))) prop))) Buffer positions start at `point-min` (usually 1) not 0, so you should probably use (max (point-min) (1- (point))) Stefan ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [elpa] externals/hcel 9dc18bef43 11/13: fixing header comments 2022-09-21 13:21 ` [elpa] externals/hcel 9dc18bef43 11/13: fixing header comments Stefan Monnier @ 2022-09-29 4:47 ` Yuchen Pei 0 siblings, 0 replies; 2+ messages in thread From: Yuchen Pei @ 2022-09-29 4:47 UTC (permalink / raw) To: Stefan Monnier; +Cc: Emacs Devel mailing list On Wed 2022-09-21 09:21:06 -0400, Stefan Monnier wrote: >> - (get-text-property (1- (point)) prop))) >> + (get-text-property (max 0 (1- (point))) prop))) > > Buffer positions start at `point-min` (usually 1) not 0, so you should > probably use (max (point-min) (1- (point))) > Thanks. Done in commit 7f73da1. Best, Yuchen -- PGP Key: 47F9 D050 1E11 8879 9040 4941 2126 7E93 EF86 DFD0 <https://ypei.org/assets/ypei-pubkey.txt> ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-29 4:47 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <166376506676.26459.702405128560499120@vcs2.savannah.gnu.org> [not found] ` <20220921125749.050E0C12D95@vcs2.savannah.gnu.org> 2022-09-21 13:21 ` [elpa] externals/hcel 9dc18bef43 11/13: fixing header comments Stefan Monnier 2022-09-29 4:47 ` Yuchen Pei
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).