From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuchen Pei Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/hcel 9dc18bef43 11/13: fixing header comments Date: Thu, 29 Sep 2022 14:47:43 +1000 Message-ID: <87r0zuwzv4.fsf@ypei.org> References: <166376506676.26459.702405128560499120@vcs2.savannah.gnu.org> <20220921125749.050E0C12D95@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37041"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: Emacs Devel mailing list To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 29 06:49:40 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odlUR-0009Py-Ez for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Sep 2022 06:49:40 +0200 Original-Received: from localhost ([::1]:46070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odlUQ-0003jN-GW for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Sep 2022 00:49:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odlSj-0002xH-MM for emacs-devel@gnu.org; Thu, 29 Sep 2022 00:47:55 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:56849) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odlSh-0007LA-PF for emacs-devel@gnu.org; Thu, 29 Sep 2022 00:47:53 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id C37235C0118; Thu, 29 Sep 2022 00:47:49 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 29 Sep 2022 00:47:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ypei.org; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1664426869; x=1664513269; bh=avFVKSjemA aMMjVWWo6z0v1Scj7sTBgaQFp26oaEri4=; b=lHRBsE05ArJoP9tezA9gEHXABV PsBnBLqB54xmgtbrF9pwTB4D9yRcl0WhBspf0C/1y6K1wPTaA70qrIv11f3A6LFn WwgLMoVLH0EbY+XCdpX2EY+RI6wY8ZV1cgyXZBvApVNMC0noHD7m69zLzf4dhNjL p67DVs7w6Qnn07DVozby3S0JxzypRCdr6jEPfMP949NAWg1QPU2hgpxsvTpHO2mY Wm/XH3uXPHvy4S45rz9+GTfKuZQJUE1qtqaetcMWhZPvR55CGmA7z+d8RmtbmFzH S6T7utj+3UGPEfE5q3q5PdQh1E6oqEpIHLLDdaB2oEOvuvV6u7ttoo4f9wcg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664426869; x=1664513269; bh=avFVKSjemAaMMjVWWo6z0v1Scj7s TBgaQFp26oaEri4=; b=hlGFbhjJ84mPQu6Qmk1lOjgeYfDntUBnepgePpXv41oD 2jmR1mLGev+Ww0fyL+JkCtxuPuaw/Ri6XbuUgauWPBbDr7+MSW790pkROCPn89YY tuUlD+pRY3a1QiExTOC1iH+hQXzjNneZKcjFRPq7SUl4kwhmSKsgT+jt2as5k/dX wukSUz7PU6UcKddkTxmM5ud72xNb2+mElsLp0ITlhhHQr3yrpa+RN7COgMOAared lCzStjEWeEieafuVt/j1qRzFF0wiYlT/gskqx4RGqVXCY3DkaxOmxdtXL3Em5e0p UyzkIO7bSC/eg5N1/2gNKG8078W+67l6Hkt0IxXVKw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegledgkeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufhffjgfkfgggtgesthdtredttdertdenucfhrhhomhepjghutghh vghnucfrvghiuceoihguseihphgvihdrohhrgheqnecuggftrfgrthhtvghrnhepfeehhf ekjeevieekheejieeufedtgeevieevjeekledvleefudefuefgheetjedunecuffhomhgr ihhnpeihphgvihdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehiugeshihpvghirdhorhhg X-ME-Proxy: Feedback-ID: i51b146f9:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Sep 2022 00:47:47 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Wed, 21 Sep 2022 09:21:06 -0400") Received-SPF: pass client-ip=66.111.4.26; envelope-from=id@ypei.org; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296440 Archived-At: On Wed 2022-09-21 09:21:06 -0400, Stefan Monnier wrote: >> - (get-text-property (1- (point)) prop))) >> + (get-text-property (max 0 (1- (point))) prop))) > > Buffer positions start at `point-min` (usually 1) not 0, so you should > probably use (max (point-min) (1- (point))) > Thanks. Done in commit 7f73da1. Best, Yuchen -- PGP Key: 47F9 D050 1E11 8879 9040 4941 2126 7E93 EF86 DFD0