unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuchen Pei <id@ypei.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs Devel mailing list <emacs-devel@gnu.org>
Subject: Re: [elpa] externals/hcel 9dc18bef43 11/13: fixing header comments
Date: Thu, 29 Sep 2022 14:47:43 +1000	[thread overview]
Message-ID: <87r0zuwzv4.fsf@ypei.org> (raw)
In-Reply-To: <jwv7d1wq2yt.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 21 Sep 2022 09:21:06 -0400")

On Wed 2022-09-21 09:21:06 -0400, Stefan Monnier wrote:

>> -      (get-text-property (1- (point)) prop)))
>> +      (get-text-property (max 0 (1- (point))) prop)))
>
> Buffer positions start at `point-min` (usually 1) not 0, so you should
> probably use (max (point-min) (1- (point)))
>

Thanks.  Done in commit 7f73da1.

Best,
Yuchen

-- 
PGP Key: 47F9 D050 1E11 8879 9040  4941 2126 7E93 EF86 DFD0
          <https://ypei.org/assets/ypei-pubkey.txt>



      reply	other threads:[~2022-09-29  4:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166376506676.26459.702405128560499120@vcs2.savannah.gnu.org>
     [not found] ` <20220921125749.050E0C12D95@vcs2.savannah.gnu.org>
2022-09-21 13:21   ` [elpa] externals/hcel 9dc18bef43 11/13: fixing header comments Stefan Monnier
2022-09-29  4:47     ` Yuchen Pei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0zuwzv4.fsf@ypei.org \
    --to=id@ypei.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).