* Re: [Emacs-diffs] trunk r113789: lisp/emacs-lisp/timer.el (timer--time): Define setter with gv-define-setter.
[not found] <E1V88KF-0002U2-9F@vcs.savannah.gnu.org>
@ 2013-08-10 13:25 ` Stefan Monnier
2013-08-10 13:26 ` Juanma Barranquero
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2013-08-10 13:25 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: emacs-devel
> + * emacs-lisp/timer.el (timer--time): Define setter with
> + gv-define-setter to avoid deprecation warning.
What was the deprecation warning?
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Emacs-diffs] trunk r113789: lisp/emacs-lisp/timer.el (timer--time): Define setter with gv-define-setter.
2013-08-10 13:25 ` [Emacs-diffs] trunk r113789: lisp/emacs-lisp/timer.el (timer--time): Define setter with gv-define-setter Stefan Monnier
@ 2013-08-10 13:26 ` Juanma Barranquero
2013-08-10 18:22 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Juanma Barranquero @ 2013-08-10 13:26 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Emacs developers
On Sat, Aug 10, 2013 at 3:25 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
> What was the deprecation warning?
In toplevel form:
emacs-lisp/timer.el:83:1:Warning: Use of deprecated ((lambda (timer time) ...)
...) form
emacs-lisp/timer.el:92:1:Warning: Use of deprecated ((lambda (timer time) ...)
...) form
emacs-lisp/timer.el:141:1:Warning: Use of deprecated ((lambda (timer time)
...) ...) form
emacs-lisp/timer.el:148:1:Warning: Use of deprecated ((lambda (timer time)
...) ...) form
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Emacs-diffs] trunk r113789: lisp/emacs-lisp/timer.el (timer--time): Define setter with gv-define-setter.
2013-08-10 13:26 ` Juanma Barranquero
@ 2013-08-10 18:22 ` Stefan Monnier
2013-08-10 19:37 ` Juanma Barranquero
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2013-08-10 18:22 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: Emacs developers
>> What was the deprecation warning?
> In toplevel form:
> emacs-lisp/timer.el:83:1:Warning: Use of deprecated ((lambda (timer time) ...)
> ...) form
> emacs-lisp/timer.el:92:1:Warning: Use of deprecated ((lambda (timer time) ...)
> ...) form
> emacs-lisp/timer.el:141:1:Warning: Use of deprecated ((lambda (timer time)
> ...) ...) form
> emacs-lisp/timer.el:148:1:Warning: Use of deprecated ((lambda (timer time)
> ...) ...) form
So the problem is in the definition of gv-define-simple-setter.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Emacs-diffs] trunk r113789: lisp/emacs-lisp/timer.el (timer--time): Define setter with gv-define-setter.
2013-08-10 18:22 ` Stefan Monnier
@ 2013-08-10 19:37 ` Juanma Barranquero
2013-08-11 3:36 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Juanma Barranquero @ 2013-08-10 19:37 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Emacs developers
On Sat, Aug 10, 2013 at 8:22 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
> So the problem is in the definition of gv-define-simple-setter.
It is a problem? It seems quite purposeful.
Anway, that definition seems more adequate for `gv-define-setter' than
`gv-define-simple-setter' IMO. Of course, it's your call.
Unrelated to the warning: the old lambda didn't return `time', and
`gv-define-simple-setter' wasn't passed the fix-return arg.
J
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] trunk r113789: lisp/emacs-lisp/timer.el (timer--time): Define setter with gv-define-setter.
2013-08-10 19:37 ` Juanma Barranquero
@ 2013-08-11 3:36 ` Stefan Monnier
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2013-08-11 3:36 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: Emacs developers
>> So the problem is in the definition of gv-define-simple-setter.
> It is a problem? It seems quite purposeful.
No, it's just an oversight. Could you fix it to use`funcall'?
> Unrelated to the warning: the old lambda didn't return `time', and
> `gv-define-simple-setter' wasn't passed the fix-return arg.
Good point, thanks,
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-08-11 3:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1V88KF-0002U2-9F@vcs.savannah.gnu.org>
2013-08-10 13:25 ` [Emacs-diffs] trunk r113789: lisp/emacs-lisp/timer.el (timer--time): Define setter with gv-define-setter Stefan Monnier
2013-08-10 13:26 ` Juanma Barranquero
2013-08-10 18:22 ` Stefan Monnier
2013-08-10 19:37 ` Juanma Barranquero
2013-08-11 3:36 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).