From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r113789: lisp/emacs-lisp/timer.el (timer--time): Define setter with gv-define-setter. Date: Sat, 10 Aug 2013 23:36:46 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1376192225 13220 80.91.229.3 (11 Aug 2013 03:37:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 11 Aug 2013 03:37:05 +0000 (UTC) Cc: Emacs developers To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 11 05:37:06 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V8MSo-0002TN-9h for ged-emacs-devel@m.gmane.org; Sun, 11 Aug 2013 05:37:06 +0200 Original-Received: from localhost ([::1]:36108 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8MSn-0004G6-KP for ged-emacs-devel@m.gmane.org; Sat, 10 Aug 2013 23:37:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8MSe-0004Fo-NZ for emacs-devel@gnu.org; Sat, 10 Aug 2013 23:37:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8MSW-0006ZF-8b for emacs-devel@gnu.org; Sat, 10 Aug 2013 23:36:56 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:53085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8MSW-0006Yt-44 for emacs-devel@gnu.org; Sat, 10 Aug 2013 23:36:48 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFLd/Nq/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYHCxQYDSSIHgbBLZEKA6R6gV6DEw X-IPAS-Result: Av4EABK/CFFLd/Nq/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYHCxQYDSSIHgbBLZEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="21373305" Original-Received: from 75-119-243-106.dsl.teksavvy.com (HELO ceviche.home) ([75.119.243.106]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 10 Aug 2013 23:36:40 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id B3F42663DD; Sat, 10 Aug 2013 23:36:46 -0400 (EDT) In-Reply-To: (Juanma Barranquero's message of "Sat, 10 Aug 2013 21:37:49 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162559 Archived-At: >> So the problem is in the definition of gv-define-simple-setter. > It is a problem? It seems quite purposeful. No, it's just an oversight. Could you fix it to use`funcall'? > Unrelated to the warning: the old lambda didn't return `time', and > `gv-define-simple-setter' wasn't passed the fix-return arg. Good point, thanks, Stefan